From: Nick Roberts <nickrob@snap.net.nz>
Cc: emacs-devel@gnu.org, Luc Teirlinck <teirllm@dms.auburn.edu>,
Miles Bader <miles@gnu.org>
Subject: Re: comint-insert-input on non-command lines: A trivial fix, a quibble, and a bug
Date: Tue, 9 May 2006 15:11:33 +1200 [thread overview]
Message-ID: <17504.2149.496291.186794@farnswood.snap.net.nz> (raw)
In-Reply-To: <17503.63124.518985.734399@rgrjr.dyndns.org>
> There is also a comment by comint-use-prompt-regexp (also present in
> 21.3):
>
> ;; Note: If it is decided to purge comint-prompt-regexp from the source
> ;; entirely, searching for uses of this variable will help to identify
> ;; places that need attention.
>
> I presume use of comint-prompt-regexp preceded the use of fields.
> Perhaps this should be purged as there's no need to use two methods and
> this would reduce the maintenance overhead.
>
> Perhaps, but that doesn't address the original issue, namely that in
> comint-mode "C-c RET" is now less useful that it had been.
You're quoting my reply to Luc. My reply to you, which you appear to have
ignored, did address the original issue.
> From: Miles Bader <miles.bader@necel.com>
> Date: Mon, 08 May 2006 13:49:19 +0900
>
> Luc Teirlinck <teirllm@dms.auburn.edu> writes:
>
> BTW, that function's use of fields is not well written.
>
> Also, it uses `posn-set-point' _after_ getting the value of (point),
> which doesn't make any sense to me.
>
> The following seems to fix both problems . . .
>
> I'll commit this unless somebody objects.
>
> But it doesn't address the original problem: "C-c RET" still does
> nothing when invoked on an output line. Please find a solution below
> that merges your changes with the guts of the comint-copy-old-input
> definition from 21.3, restoring the original behavior. If that is
> satisfactory to everyone, then I will undertake to ensure that all of
> the documentation is consistent.
I've already said why I don't like it. We haven't reached an agreement
yet that this behaviour is desirable.
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2006-05-09 3:11 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-06 20:05 comint-insert-input on non-command lines: A trivial fix, a quibble, and a bug Bob Rogers
2006-05-08 0:31 ` Nick Roberts
2006-05-08 3:16 ` Luc Teirlinck
2006-05-08 3:49 ` Luc Teirlinck
2006-05-08 4:49 ` Miles Bader
2006-05-08 14:08 ` Stefan Monnier
2006-05-09 2:33 ` Miles Bader
2006-05-08 4:08 ` Luc Teirlinck
2006-05-08 4:18 ` Nick Roberts
2006-05-09 1:55 ` Bob Rogers
2006-05-09 3:11 ` Nick Roberts [this message]
2006-05-10 3:01 ` Bob Rogers
2006-05-10 5:57 ` Nick Roberts
2006-05-09 3:01 ` Luc Teirlinck
2006-05-09 3:21 ` Nick Roberts
2006-05-09 3:59 ` Luc Teirlinck
2006-05-09 6:17 ` Nick Roberts
2006-05-09 14:58 ` Luc Teirlinck
2006-05-10 1:09 ` Nick Roberts
2006-05-10 1:13 ` Luc Teirlinck
2006-05-10 1:58 ` Miles Bader
2006-05-10 2:21 ` Nick Roberts
2006-05-10 2:32 ` Miles Bader
2006-05-10 3:50 ` Nick Roberts
2006-05-10 4:09 ` Miles Bader
2006-05-10 4:41 ` Luc Teirlinck
2006-05-10 5:29 ` Nick Roberts
2006-05-10 6:06 ` Luc Teirlinck
2006-05-10 6:27 ` Miles Bader
2006-05-10 21:38 ` comint-insert-input on non-command lines: Nick Roberts
2006-05-11 1:12 ` Luc Teirlinck
2006-05-11 1:33 ` Luc Teirlinck
2006-05-11 18:31 ` Richard Stallman
2006-05-11 20:29 ` Nick Roberts
2006-05-11 22:40 ` Luc Teirlinck
2006-05-14 23:29 ` Richard Stallman
2006-05-15 3:46 ` Luc Teirlinck
2006-05-15 20:37 ` Richard Stallman
2006-05-28 2:11 ` Luc Teirlinck
2006-05-28 3:48 ` Luc Teirlinck
2006-05-29 3:41 ` Nick Roberts
2006-05-29 3:58 ` Luc Teirlinck
2006-05-31 3:14 ` Luc Teirlinck
2006-05-31 3:24 ` Bob Rogers
2006-05-09 4:15 ` comint-insert-input on non-command lines: A trivial fix, a quibble, and a bug Luc Teirlinck
2006-05-10 5:19 ` Luc Teirlinck
2006-05-10 6:04 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17504.2149.496291.186794@farnswood.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=teirllm@dms.auburn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).