From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Aidan Kehoe Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Unicode Lisp reader escapes Date: Wed, 3 May 2006 00:50:15 +0200 Message-ID: <17495.57895.90438.848865@parhasard.net> References: <17491.34779.959316.484740@parhasard.net> <17495.932.70900.796282@parhasard.net> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1146610237 12759 80.91.229.2 (2 May 2006 22:50:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 2 May 2006 22:50:37 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 03 00:50:34 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fb3hN-0003ON-VN for ged-emacs-devel@m.gmane.org; Wed, 03 May 2006 00:50:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fb3hN-0002kz-Gx for ged-emacs-devel@m.gmane.org; Tue, 02 May 2006 18:50:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fb3hC-0002jO-7C for emacs-devel@gnu.org; Tue, 02 May 2006 18:50:18 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fb3hA-0002jC-LR for emacs-devel@gnu.org; Tue, 02 May 2006 18:50:17 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fb3hA-0002j9-G7 for emacs-devel@gnu.org; Tue, 02 May 2006 18:50:16 -0400 Original-Received: from [66.111.49.30] (helo=icarus.asclepian.ie) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fb3hP-0008Jk-Sm for emacs-devel@gnu.org; Tue, 02 May 2006 18:50:32 -0400 Original-Received: by icarus.asclepian.ie (Postfix, from userid 1003) id 821538008C; Tue, 2 May 2006 23:50:15 +0100 (IST) Original-To: Kenichi Handa In-Reply-To: X-Mailer: VM 7.17 under 21.5 (beta25) "eggplant" (+CVS-20060325) XEmacs Lucid X-Echelon-distraction: PTT Guppy warez W3 IWIS the Foundation X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53824 Archived-At: Ar an dara l=C3=A1 de m=C3=AD Bealtaine, scr=C3=ADobh Kenichi Handa:=20 > > Yay, a technical objection.=20 >=20 > > If it isn=E2=80=99t safe to call a Lisp program in read_escape, then= the > > function is full of bugs already. It=E2=80=99s called with three arg= uments, a > > Lisp_Object readcharfun, an integer, and a pointer to an integer. If > > readcharfun is a Lisp function (it may not be, it may be a buffer, a > > marker, or a string), then that Lisp function is called on line 348.= =20 > > Cf. the documentation of `read', which describes that the input may = be > > from a function. >=20 > What I concern is the case that readcharfun is a string or a buffer. I= n > that case, of course, the current code doesn't call Lisp in read_escap= e. > So, there's no need of GCPRO readcharfun. > > But, if Lisp is called even if readcharfun is a string, I think we sho= uld > GCPRO it. Is it already done? (Sorry, I don't have a time to check > lread.c by myself) I=E2=80=99m reasonably sure it=E2=80=99s already done in the callers of r= ead1, but I don=E2=80=99t have graphing software to hand, and the English for the reasoning I=E2=80= =99ve written out is unreadably tedious. So, sure, GCPROing seems worth the tim= e.=20 Do you mean to GCPRO independent of what type readcharfun is?=20 --=20 Aidan Kehoe, http://www.parhasard.net/