From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Aidan Kehoe Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Unicode Lisp reader escapes Date: Tue, 2 May 2006 13:13:00 +0200 Message-ID: <17495.16060.386251.695636@parhasard.net> References: <17491.34779.959316.484740@parhasard.net> <17495.932.70900.796282@parhasard.net> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1146568412 12510 80.91.229.2 (2 May 2006 11:13:32 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 2 May 2006 11:13:32 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 02 13:13:20 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fasoc-0006Y7-2s for ged-emacs-devel@m.gmane.org; Tue, 02 May 2006 13:13:14 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fasob-0000wp-H5 for ged-emacs-devel@m.gmane.org; Tue, 02 May 2006 07:13:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FasoQ-0000wT-DU for emacs-devel@gnu.org; Tue, 02 May 2006 07:13:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FasoP-0000wH-VA for emacs-devel@gnu.org; Tue, 02 May 2006 07:13:02 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FasoP-0000wA-TE for emacs-devel@gnu.org; Tue, 02 May 2006 07:13:01 -0400 Original-Received: from [66.111.49.30] (helo=icarus.asclepian.ie) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FasoX-0004JT-S2; Tue, 02 May 2006 07:13:09 -0400 Original-Received: by icarus.asclepian.ie (Postfix, from userid 1003) id 784688008D; Tue, 2 May 2006 12:13:00 +0100 (IST) Original-To: Eli Zaretskii In-Reply-To: X-Mailer: VM 7.17 under 21.5 (beta25) "eggplant" (+CVS-20060325) XEmacs Lucid X-Echelon-distraction: CNCIS SASP ID CCS arrangements Furby X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53783 Archived-At: Ar an dara l=C3=A1 de m=C3=AD Bealtaine, scr=C3=ADobh Eli Zaretskii:=20 > > > First of all, is it safe to call Lisp program in read_escape? Don= 't we > > > have to care about GC and buffer/string-data relocation? > >=20 > > Yay, a technical objection.=20 >=20 > I don't know what you mean: the other objections were technical as > well. I would rate questions of aesthetics (=E2=80=9Cugliness=E2=80=9D) and pro= se style as non-technical. I don=E2=80=99t propose to impose that judgement on you, b= ut I do think it reasonable. > > If it isn't safe to call a Lisp program in read_escape, then the > > function is full of bugs already. >=20 > ``Full of bugs''? Indeed; each READCHAR can call arbitrary Lisp, so something like case 'M': c =3D READCHAR; if (c !=3D '-') error ("Invalid escape character syntax"); c =3D READCHAR; if (c =3D=3D '\\') c =3D read_escape (readcharfun, 0, byterep); return c | meta_modifier; has two clear bugs in eight lines.=20 --=20 Aidan Kehoe, http://www.parhasard.net/