diff-function face

diff-function face

[Nick Roberts]

Currently diff-function face inherits from diff-context and looks like
its part of the diff hunk.  I presume this is a mistake as its really
part of the header.  In any case I find a diff is a lot easier to view 
if diff-function inherits from diff-header.

[Please note that the function is only visible if you have something like:

(setq diff-switches "-cp")

in your .emacs and works for C functions]

OK to apply?


-- 
Nick                                           http://www.inet.net.nz/~nickrob


*** diff-mode.el	07 Feb 2006 10:13:32 +1300	1.84
--- diff-mode.el	18 Mar 2006 00:19:09 +1300	
*************** when editing big diffs)."
*** 274,280 ****
  (defvar diff-indicator-changed-face 'diff-indicator-changed)
  
  (defface diff-function
!   '((t :inherit diff-context))
    "`diff-mode' face used to highlight function names produced by \"diff -p\"."
    :group 'diff-mode)
  ;; backward-compatibility alias
--- 274,280 ----
  (defvar diff-indicator-changed-face 'diff-indicator-changed)
  
  (defface diff-function
!   '((t :inherit diff-header))
    "`diff-mode' face used to highlight function names produced by \"diff -p\"."
    :group 'diff-mode)
  ;; backward-compatibility alias

Re: diff-function face

[Richard Stallman]

    Currently diff-function face inherits from diff-context and looks like
    its part of the diff hunk.  I presume this is a mistake as its really
    part of the header.  In any case I find a diff is a lot easier to view 
    if diff-function inherits from diff-header.

Wouldn't it be better if this were different from the rest of the
hunk?  That would help it stand out.  Perhaps it should inherit from
some other face, neither diff-header nor diff-function.

Re: diff-function face

[Nick Roberts]

 >     Currently diff-function face inherits from diff-context and looks like
 >     its part of the diff hunk.  I presume this is a mistake as its really
 >     part of the header.  In any case I find a diff is a lot easier to view 
 >     if diff-function inherits from diff-header.
 > 
 > Wouldn't it be better if this were different from the rest of the
 > hunk?  That would help it stand out.  Perhaps it should inherit from
 > some other face, neither diff-header nor diff-function.

More faces doesn't always mean better (I think compilation mode proves that).
It could draw attention away from other equally important parts of the patch.
Either way I don't really mind.  I just think it shouldn't inherit from
diff-context.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: diff-function face

[Stefan Monnier]

> Currently diff-function face inherits from diff-context and looks like
> its part of the diff hunk.  I presume this is a mistake as its really
> part of the header.  In any case I find a diff is a lot easier to view
> if diff-function inherits from diff-header.

I don't have much preference here, but just to give some context (pun
intended): I decided to inherit from diff-context because the function-info
is really just that: context.  Also, in many cases this info is useless
(because the naive heuristic used to find the function name works OK for
C but not for much else), so I'd rather have it be discrete.


        Stefan

Re: diff-function face

[Nick Roberts]

Stefan Monnier writes:
 > > Currently diff-function face inherits from diff-context and looks like
 > > its part of the diff hunk.  I presume this is a mistake as its really
 > > part of the header.  In any case I find a diff is a lot easier to view
 > > if diff-function inherits from diff-header.
 > 
 > I don't have much preference here, but just to give some context (pun
 > intended): I decided to inherit from diff-context because the function-info
 > is really just that: context.  Also, in many cases this info is useless
 > (because the naive heuristic used to find the function name works OK for
 > C but not for much else), so I'd rather have it be discrete.
                                                     (discreet?)

Yes, thats a good reason for not using a face other than diff-context
or diff-header.

-- 
Nick                                           http://www.inet.net.nz/~nickrob