* Patch: blue underlined for button face and fill in apropos
@ 2006-02-18 22:40 Lennart Borgman
2006-02-19 0:29 ` Nick Roberts
2006-02-19 17:17 ` Juri Linkov
0 siblings, 2 replies; 5+ messages in thread
From: Lennart Borgman @ 2006-02-18 22:40 UTC (permalink / raw
[-- Attachment #1: Type: text/plain, Size: 428 bytes --]
Here are some small patches I have not had time to propose before. The
first one changes the color to blue for `button' face. This is the
underlined face used in help.
I have suggested this before, but without sending a patch.
The second patch sets the default for `apropos-label-face' to `button'
(above). It also adds filling of of values in the list shown by M-x
apropos. I believe this makes the list more readable.
[-- Attachment #2: button-blue.patch --]
[-- Type: text/plain, Size: 835 bytes --]
Index: lisp/button.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/button.el,v
retrieving revision 1.21
diff -c -r1.21 button.el
*** lisp/button.el 6 Feb 2006 14:33:32 -0000 1.21
--- lisp/button.el 18 Feb 2006 22:30:37 -0000
***************
*** 54,60 ****
;; Use color for the MS-DOS port because it doesn't support underline.
(defface button '((((type pc) (class color))
(:foreground "lightblue"))
! (t :underline t))
"Default face used for buttons."
:group 'basic-faces)
--- 54,60 ----
;; Use color for the MS-DOS port because it doesn't support underline.
(defface button '((((type pc) (class color))
(:foreground "lightblue"))
! (t :underline t :foreground "blue"))
"Default face used for buttons."
:group 'basic-faces)
[-- Attachment #3: apropos-button-and-fill.patch --]
[-- Type: text/plain, Size: 2133 bytes --]
Index: lisp/apropos.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/apropos.el,v
retrieving revision 1.114
diff -c -r1.114 apropos.el
*** lisp/apropos.el 6 Feb 2006 14:33:31 -0000 1.114
--- lisp/apropos.el 18 Feb 2006 22:33:04 -0000
***************
*** 85,91 ****
:group 'apropos
:type 'face)
! (defcustom apropos-label-face 'italic
"*Face for label (`Command', `Variable' ...) in Apropos output.
A value of nil means don't use any special font for them, and also
turns off mouse highlighting."
--- 85,91 ----
:group 'apropos
:type 'face)
! (defcustom apropos-label-face 'button
"*Face for label (`Command', `Variable' ...) in Apropos output.
A value of nil means don't use any special font for them, and also
turns off mouse highlighting."
***************
*** 980,994 ****
(if (stringp (setq i (nth i apropos-item)))
(progn
(insert " ")
! (insert-text-button (button-type-get type 'apropos-label)
! 'type type
! ;; Can't use the default button face, since
! ;; user may have changed the variable!
! ;; Just say `no' to variables containing faces!
! 'face apropos-label-face
! 'apropos-symbol (car apropos-item))
! (insert ": ")
! (insert (if do-keys (substitute-command-keys i) i))
(or (bolp) (terpri)))))
--- 980,996 ----
(if (stringp (setq i (nth i apropos-item)))
(progn
(insert " ")
! (let ((start (point)))
! (insert-text-button (button-type-get type 'apropos-label)
! 'type type
! ;; Can't use the default button face, since
! ;; user may have changed the variable!
! ;; Just say `no' to variables containing faces!
! 'face apropos-label-face
! 'apropos-symbol (car apropos-item))
! (insert ": ")
! (insert (if do-keys (substitute-command-keys i) i))
! (fill-region start (point)))
(or (bolp) (terpri)))))
[-- Attachment #4: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Patch: blue underlined for button face and fill in apropos
2006-02-18 22:40 Patch: blue underlined for button face and fill in apropos Lennart Borgman
@ 2006-02-19 0:29 ` Nick Roberts
2006-02-19 1:16 ` Chong Yidong
2006-02-19 17:17 ` Juri Linkov
1 sibling, 1 reply; 5+ messages in thread
From: Nick Roberts @ 2006-02-19 0:29 UTC (permalink / raw
Cc: Emacs Devel
> Here are some small patches I have not had time to propose before. The
> first one changes the color to blue for `button' face. This is the
> underlined face used in help.
I have patches going back over a year for help buttons. One feature is to use
the faces info-xref and info-xref-visited to keep track of references already
visited like in info, but apparently we're in a feature freeze...
--
Nick http://www.inet.net.nz/~nickrob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch: blue underlined for button face and fill in apropos
2006-02-19 0:29 ` Nick Roberts
@ 2006-02-19 1:16 ` Chong Yidong
0 siblings, 0 replies; 5+ messages in thread
From: Chong Yidong @ 2006-02-19 1:16 UTC (permalink / raw
Cc: Lennart Borgman, Emacs Devel
Nick Roberts <nickrob@snap.net.nz> writes:
> > Here are some small patches I have not had time to propose before. The
> > first one changes the color to blue for `button' face. This is the
> > underlined face used in help.
>
> I have patches going back over a year for help buttons. One feature is to use
> the faces info-xref and info-xref-visited to keep track of references already
> visited like in info, but apparently we're in a feature freeze...
An exceedingly leaky one, that has seen the addition of a new
thumbnail package and two IRC clients.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch: blue underlined for button face and fill in apropos
2006-02-18 22:40 Patch: blue underlined for button face and fill in apropos Lennart Borgman
2006-02-19 0:29 ` Nick Roberts
@ 2006-02-19 17:17 ` Juri Linkov
2006-02-19 21:08 ` Lennart Borgman
1 sibling, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2006-02-19 17:17 UTC (permalink / raw
Cc: emacs-devel
> Here are some small patches I have not had time to propose before. The
> first one changes the color to blue for `button' face. This is the
> underlined face used in help.
>
> I have suggested this before, but without sending a patch.
>
> The second patch sets the default for `apropos-label-face' to `button'
> (above).
I welcome your patches, but suggest using the `link' face for both
`button' and `apropos-label-face'.
--
Juri Linkov
http://www.jurta.org/emacs/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch: blue underlined for button face and fill in apropos
2006-02-19 17:17 ` Juri Linkov
@ 2006-02-19 21:08 ` Lennart Borgman
0 siblings, 0 replies; 5+ messages in thread
From: Lennart Borgman @ 2006-02-19 21:08 UTC (permalink / raw
Cc: emacs-devel
Juri Linkov wrote:
>> Here are some small patches I have not had time to propose before. The
>> first one changes the color to blue for `button' face. This is the
>> underlined face used in help.
>>
>> I have suggested this before, but without sending a patch.
>>
>> The second patch sets the default for `apropos-label-face' to `button'
>> (above).
>>
>
> I welcome your patches, but suggest using the `link' face for both
> `button' and `apropos-label-face'.
>
That sounds very good to me.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-02-19 21:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-18 22:40 Patch: blue underlined for button face and fill in apropos Lennart Borgman
2006-02-19 0:29 ` Nick Roberts
2006-02-19 1:16 ` Chong Yidong
2006-02-19 17:17 ` Juri Linkov
2006-02-19 21:08 ` Lennart Borgman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).