From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ulf Jasper Newsgroups: gmane.emacs.devel Subject: Re: newsticker-start: Recursive laod error Date: Thu, 15 Dec 2005 21:18:10 +0100 Message-ID: <17313.53122.472361.535552@andromeda.eppjasopp.de> References: <873bkzhnfe.fsf@pacem.orebokech.com> <17309.50116.806660.681190@andromeda.eppjasopp.de> <17312.28917.411699.419515@andromeda.eppjasopp.de> Reply-To: ulf.jasper@web.de NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1134683599 21188 80.91.229.2 (15 Dec 2005 21:53:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 15 Dec 2005 21:53:19 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 15 22:53:17 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1En0yc-0001dM-G0 for ged-emacs-devel@m.gmane.org; Thu, 15 Dec 2005 22:49:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1En0zH-0003BB-BM for ged-emacs-devel@m.gmane.org; Thu, 15 Dec 2005 16:50:07 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Emzb1-0007OW-3K for emacs-devel@gnu.org; Thu, 15 Dec 2005 15:21:02 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Emzab-0007B6-An for emacs-devel@gnu.org; Thu, 15 Dec 2005 15:20:50 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Emzaa-0007Am-HZ for emacs-devel@gnu.org; Thu, 15 Dec 2005 15:20:32 -0500 Original-Received: from [81.169.145.165] (helo=natsmtp00.rzone.de) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EmzcB-0006ac-FU; Thu, 15 Dec 2005 15:22:13 -0500 Original-Received: from andromeda.eppjasopp.de (p54B0128C.dip0.t-ipconnect.de [84.176.18.140]) by post.webmailer.de (8.13.1/8.13.1) with ESMTP id jBFKIADA024088; Thu, 15 Dec 2005 21:18:11 +0100 (MET) Original-To: Thien-Thi Nguyen , emacs-devel@gnu.org In-Reply-To: , 14 December 2005 19:35:36 -0500 X-Mailer: VM 7.19 under Emacs 22.0.50.2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:47822 Archived-At: OK. I cut out the '-p' thing. The recursive load error should be fixed now. Here's the patch Prost! ulf *** newsticker.el 15 Dez 2005 19:34:02 +0100 1.8 --- newsticker.el 15 Dez 2005 20:53:51 +0100 *************** *** 9,15 **** ;; URL: http://www.nongnu.org/newsticker ;; Created: 17. June 2003 ;; Keywords: News, RSS, Atom ! ;; Time-stamp: "1. November 2005, 21:16:53 (ulf)" ;; ====================================================================== --- 9,15 ---- ;; URL: http://www.nongnu.org/newsticker ;; Created: 17. June 2003 ;; Keywords: News, RSS, Atom ! ;; Time-stamp: "15. Dezember 2005, 20:53:51 (ulf)" ;; ====================================================================== *************** *** 27,33 **** ;; along with this program; if not, write to the Free Software Foundation, ;; Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. ! (defconst newsticker-version "1.9" "Version number of newsticker.el.") ;; ====================================================================== ;;; Commentary: --- 27,33 ---- ;; along with this program; if not, write to the Free Software Foundation, ;; Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. ! (defconst newsticker-version "1.91" "Version number of newsticker.el.") ;; ====================================================================== ;;; Commentary: *************** *** 169,174 **** --- 169,181 ---- ;; ====================================================================== ;;; History: + ;; 1.91 (2005-12-15) + ;; * Renamed `newsticker--retrieval-timer-list' to + ;; `newsticker-retrieval-timer-list'. Removed + ;; `newsticker-running-p' -- check newsticker-retrieval-timer-list + ;; to find out whether newsticker is running. Removed + ;; `newsticker-ticker-running-p'. + ;; 1.9 (2005-11-01) ;; * Rewrote feed parsing part. Newsticker now supports RSS 0.91, ;; 0.92, 1.0, 2.0 as well as Atom 0.3 and 1.0 -- thanks to Thien-Thi *************** *** 453,458 **** --- 460,470 ---- (setq element (cdr element))) result)) + ;;;###autoload + (defvar newsticker-retrieval-timer-list nil + "List of timers for news retrieval. + This is an alist, each element consisting of (feed-name . timer)") + ;; ====================================================================== ;;; Customization ;; ====================================================================== *************** *** 475,488 **** ((memq symbol '(newsticker-url-list-defaults newsticker-url-list newsticker-retrieval-interval)) ! (when (and (fboundp 'newsticker-running-p) ! (newsticker-running-p)) (message "Restarting newsticker") (newsticker-stop) (newsticker-start))) ((eq symbol 'newsticker-display-interval) ! (when (and (fboundp 'newsticker-running-p) ! (newsticker-running-p)) (message "Restarting ticker") (newsticker-stop-ticker) (newsticker-start-ticker) --- 487,498 ---- ((memq symbol '(newsticker-url-list-defaults newsticker-url-list newsticker-retrieval-interval)) ! (when newsticker-retrieval-timer-list (message "Restarting newsticker") (newsticker-stop) (newsticker-start))) ((eq symbol 'newsticker-display-interval) ! (when newsticker-retrieval-timer-list (message "Restarting ticker") (newsticker-stop-ticker) (newsticker-start-ticker) *************** *** 490,497 **** ((memq symbol '(newsticker-hide-old-items-in-echo-area newsticker-hide-obsolete-items-in-echo-area newsticker-hide-immortal-items-in-echo-area)) ! (when (and (fboundp 'newsticker-running-p) ! (newsticker-running-p)) (message "Restarting newsticker") (newsticker-stop-ticker) (newsticker--ticker-text-setup) --- 500,506 ---- ((memq symbol '(newsticker-hide-old-items-in-echo-area newsticker-hide-obsolete-items-in-echo-area newsticker-hide-immortal-items-in-echo-area)) ! (when newsticker-retrieval-timer-list (message "Restarting newsticker") (newsticker-stop-ticker) (newsticker--ticker-text-setup) *************** *** 1190,1198 **** ;; ====================================================================== (defvar newsticker--display-timer nil "Timer for newsticker display.") - (defvar newsticker--retrieval-timer-list nil - "List of timers for news retrieval. - This is an alist, each element consisting of (feed-name . timer)") (defvar newsticker--item-list nil "List of newsticker items.") (defvar newsticker--item-position 0 --- 1199,1204 ---- *************** *** 2372,2378 **** DO-NOT-COMPLAIN-IF-RUNNING is not nil. Run `newsticker-start-hook' if newsticker was not running already." (interactive) ! (let ((running (newsticker-running-p))) ;; read old cache if it exists and newsticker is not running (unless running (let* ((coding-system-for-read 'utf-8) --- 2378,2384 ---- DO-NOT-COMPLAIN-IF-RUNNING is not nil. Run `newsticker-start-hook' if newsticker was not running already." (interactive) ! (let ((running newsticker-retrieval-interval)) ;; read old cache if it exists and newsticker is not running (unless running (let* ((coding-system-for-read 'utf-8) *************** *** 2393,2399 **** (interval (or (nth 3 item) newsticker-retrieval-interval)) (timer (assoc (car item) ! newsticker--retrieval-timer-list))) (if timer (or do-not-complain-if-running (message "Timer for %s is running already!" --- 2399,2405 ---- (interval (or (nth 3 item) newsticker-retrieval-interval)) (timer (assoc (car item) ! newsticker-retrieval-timer-list))) (if timer (or do-not-complain-if-running (message "Timer for %s is running already!" *************** *** 2411,2417 **** (setq timer (run-at-time start-time interval 'newsticker-get-news feed-name)) (if interval ! (add-to-list 'newsticker--retrieval-timer-list (cons feed-name timer)))))) (append newsticker-url-list-defaults newsticker-url-list)) (unless running --- 2417,2423 ---- (setq timer (run-at-time start-time interval 'newsticker-get-news feed-name)) (if interval ! (add-to-list 'newsticker-retrieval-timer-list (cons feed-name timer)))))) (append newsticker-url-list-defaults newsticker-url-list)) (unless running *************** *** 2438,2448 **** (interactive) (newsticker--cache-update t) (newsticker-stop-ticker) ! (when (newsticker-running-p) (mapc (lambda (name-and-timer) (cancel-timer (cdr name-and-timer))) ! newsticker--retrieval-timer-list) ! (setq newsticker--retrieval-timer-list nil) (run-hooks 'newsticker-stop-hook) (message "Newsticker stopped!"))) --- 2444,2454 ---- (interactive) (newsticker--cache-update t) (newsticker-stop-ticker) ! (when newsticker-retrieval-timer-list (mapc (lambda (name-and-timer) (cancel-timer (cdr name-and-timer))) ! newsticker-retrieval-timer-list) ! (setq newsticker-retrieval-timer-list nil) (run-hooks 'newsticker-stop-hook) (message "Newsticker stopped!"))) *************** *** 3079,3102 **** (and (memq age '(new old obsolete)) t))))) ;; ====================================================================== - ;;; Newsticker status - ;; ====================================================================== - ;;;###autoload - (defun newsticker-running-p () - "Check whether newsticker is running. - Return t if newsticker is running, nil otherwise. Newsticker is - considered to be running if the newsticker timer list is not empty." - (> (length newsticker--retrieval-timer-list) 0)) - - ;;;###autoload - (defun newsticker-ticker-running-p () - "Check whether newsticker's actual ticker is running. - Return t if ticker is running, nil otherwise. Newsticker is - considered to be running if the newsticker timer list is not - empty." - (timerp newsticker--display-timer)) - - ;; ====================================================================== ;;; local stuff ;; ====================================================================== (defun newsticker-get-news (feed-name) --- 3085,3090 ----