From: Nick Roberts <nickrob@snap.net.nz>
Cc: ismail@uludag.org.tr, emacs-devel@gnu.org
Subject: Re: Options menu is broken on CVS
Date: Thu, 8 Sep 2005 16:24:50 +1200 [thread overview]
Message-ID: <17183.48402.585456.467736@farnswood.snap.net.nz> (raw)
In-Reply-To: <uirxcw73p.fsf@gnu.org>
> > I think this is the right fix.
>
> Please describe the reasons why you think this is the right fix.
menu-updating-buffers is defined in syms_of_xmenu (). Currently syms_of_xmenu
is only called in emacs.c if HAVE_MENUS is true. menu-updating-buffers is
needed even if Emacs is configured without X (on GNU/Linux at least) but in
this case HAVE_MENUS is not defined.
xmenu.c is needed even HAVE_X_WINDOWS is not defined so I've moved it outside
the conditional requiring it.
> (I'm
> assuming you've read the discussions from 2004 that led to the
> original changes.)
I might not have followed it all but your change seemed to cover Carbon Emacs
which it still does:
#ifndef HAVE_CARBON
XMENU_OBJ = xmenu.o
#endif
Now I've moved it outside #ifdef HAVE_X_WINDOWS you might need to add
another condition for when w32menu.o is used, I'm not sure.
> > Actually I think the problem was caused by Kim's change:
> >
> > 2004-03-11 Kim F. Storm <storm@cua.dk>
> >
> > * Makefile.in:...
> > (XMENU_OBJ) [HAVE_MENUS]: Move declaration to proper place.
>
> That change was made for a reason as well: some problem on Carbon. We
> need to understand that problem, to be sure your change will not
> reintroduce it. I hope that the explanations I asked for above will
> clarify this (I still didn't have time to re-read those past
> discussions and retrace what problems we were trying to fix.)
I didn't find the discussion that led to this change. It might have been
part of a general tidying process.
> In addition, we need to explain why the OP says he started to see the
> problem only recently.
I've tried to explain that in another post: more calls to menu-updating-frame
have been made in menu-bar.el (26/08/05).
> > The preamble for xmenu.c says:
> >
> > /* X Communication module for terminals which understand the X protocol.
> >
> > but xmenu.c is more general than that and compiles without X. Even its
> > name is misleading (as with xdisp.c which also compiles without X).
>
> That's history: xmenu.c was originally written for X, but then menu
> support was added to the DOS port and later came tmm. If you think
> the name xmenu tricked Kim and myself into thinking it's only for X,
> that was not the reason.
I don't have an opinion on whether you or Kim were tricked, just that the
description is misleading and that xmenu.c is needed even HAVE_X_WINDOWS is
not defined.
Nick
next prev parent reply other threads:[~2005-09-08 4:24 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 17:07 Options menu is broken on CVS İsmail Dönmez
2005-09-06 20:45 ` Nick Roberts
2005-09-06 20:49 ` İsmail Dönmez
2005-09-06 23:01 ` Nick Roberts
2005-09-07 4:16 ` Eli Zaretskii
2005-09-07 14:58 ` İsmail Dönmez
2005-09-07 18:04 ` Eli Zaretskii
2005-09-07 18:13 ` İsmail Dönmez
2005-09-07 22:11 ` Nick Roberts
[not found] ` <20050907223612.GA7445@uludag.org.tr>
2005-09-07 23:27 ` Nick Roberts
2005-09-07 22:04 ` Nick Roberts
2005-09-08 3:50 ` Eli Zaretskii
2005-09-08 4:24 ` Nick Roberts [this message]
2005-09-08 19:33 ` Eli Zaretskii
2005-09-09 11:50 ` Eli Zaretskii
2005-09-09 13:12 ` Nick Roberts
2005-09-09 13:49 ` Eli Zaretskii
2005-09-09 23:07 ` Nick Roberts
2005-09-10 9:28 ` Eli Zaretskii
2005-09-10 11:09 ` Eli Zaretskii
2005-09-09 13:46 ` Eli Zaretskii
2005-09-09 15:47 ` David Kastrup
2005-09-09 18:23 ` Eli Zaretskii
2005-09-10 0:08 ` YAMAMOTO Mitsuharu
2005-09-10 9:18 ` Eli Zaretskii
2005-09-11 6:54 ` Richard M. Stallman
2005-09-11 19:51 ` Eli Zaretskii
2005-09-12 15:34 ` Richard M. Stallman
2005-09-09 18:12 ` Stefan Monnier
2005-09-09 18:18 ` Eli Zaretskii
2005-09-10 0:18 ` YAMAMOTO Mitsuharu
2005-09-08 9:04 ` Richard M. Stallman
2005-09-08 9:50 ` İsmail Dönmez
2005-09-08 2:41 ` Richard M. Stallman
2005-09-08 3:39 ` Eli Zaretskii
2005-09-08 21:02 ` Stefan Monnier
2005-09-09 10:41 ` Eli Zaretskii
2005-09-09 13:06 ` Stefan Monnier
2005-09-09 17:40 ` Bug repository Bill Wohler
2005-09-10 6:12 ` Miles Bader
2005-09-10 8:13 ` Richard M. Stallman
2005-09-10 8:14 ` Options menu is broken on CVS Richard M. Stallman
2005-09-10 8:48 ` Eli Zaretskii
2005-09-11 6:54 ` Richard M. Stallman
2005-09-11 9:36 ` Refering to bug reports (was: Options menu is broken on CVS) Reiner Steib
2005-09-12 15:33 ` Richard M. Stallman
2005-09-11 19:54 ` Options menu is broken on CVS Eli Zaretskii
2005-09-12 15:33 ` Richard M. Stallman
[not found] <131DDC775E8EB841AD6D175CDF410DCE0311C1D0@payload.camelot.bsquare.com>
2005-09-06 18:32 ` İsmail Dönmez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17183.48402.585456.467736@farnswood.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=emacs-devel@gnu.org \
--cc=ismail@uludag.org.tr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).