From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: master 74bb1e5897f 2/3: Fix filling in c-ts-mode (bug#72116) Date: Sun, 4 Aug 2024 20:50:41 -0700 Message-ID: <171796ED-921A-472C-8682-C1252EA265B0@gmail.com> References: <172238461549.32268.17283604138559769854@vcs2.savannah.gnu.org> <20240731001020.DEFADC1CAE9@vcs2.savannah.gnu.org> <8F99C2F8-F88E-4662-B2E8-70592DBAEAC8@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37094"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 05 05:51:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1saokh-0009UV-P9 for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Aug 2024 05:51:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1saokO-0005C3-Qr; Sun, 04 Aug 2024 23:51:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saokM-0005Bm-3f for emacs-devel@gnu.org; Sun, 04 Aug 2024 23:50:58 -0400 Original-Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1saokK-0005Di-MN; Sun, 04 Aug 2024 23:50:57 -0400 Original-Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-6e7b121be30so6359699a12.1; Sun, 04 Aug 2024 20:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722829853; x=1723434653; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=baDHzXAKxfJCZdbkD60/hTRwTlLRbBPFm8oJ38fJf6U=; b=QDGhgY/AlzbTYKfQ+PxUHmYgDS0W9vpqLZt6wqUChGIH+fgBVthAaoYd6rzOlZBMF6 +c9zfa+GpPJsiey8jLbmxnTTO4uX9QCtkU1EXqHAv448sEJTVggIMoCnnaH2Anxb7Zg+ pj0P7EkkIwKrQgHnAggPkc2pk+CkzmpNr/FgoBYQDM12lZujfs3W/ngs6Xu7ewlEgCbW QOLh0du/9j/cSWTQyYuSVVDpTgSbJRXQ9XO4r+ydrG3/DtlZGuzEL7EOQ/EcKbNwlyiH CQlW4vb5ajg4Lwi5T24EPts2IgaWTVWVTUr7FBRGO4K3I7DhVhhOlXB7Cx29uzEgV5M1 HvKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722829853; x=1723434653; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=baDHzXAKxfJCZdbkD60/hTRwTlLRbBPFm8oJ38fJf6U=; b=NswrgU9Gj6tOhnqbxeM8hm+KSxDlU0ktCxMRu7hbJV/ui+UMuPbfCRVrd8IGvDHN6K AdvoaWq2XNaCIi9Sa7LDB0y5RFz2gctfurtf8wLkI3UCcve9gnoHZ7tllSbW0s86e92g 9azwqXhW8rxHwca8Ny6qshiw/t4IPOcDax4FAxG10IccY0OUMyLTZciYACg396AAdM/V YEIJRb2C/uLjSJF8BlO3Ddc4vIVdpsbgt71cy9x//aL98VuKSilGQyYGLebYMjT4OEmC 54aVk/ErV+vS0vtd7ZWBdOeKJwx+BI7PmtCTS5qADF4nmfSKMAQoCUMddhXqG/ZtKlmp 90rg== X-Gm-Message-State: AOJu0Yxh3cemCBe/ZGkFnSXphjRwujJflIrtRJ9Gb2RjC5/uUjXxtORv ozpY6WWgQnsIeSBtdzdwOdaPJMje1LOErRQ5Up6q8HkRYbUGnGeqclRNUg== X-Google-Smtp-Source: AGHT+IHfo2hDlDu9qPxBdobCGqf3JKkQYGHtQJX+DxalKTfMffng5mPmkkEZlelUTD3zo0yxGrOaEw== X-Received: by 2002:a17:90b:23d4:b0:2c9:81c6:b0e7 with SMTP id 98e67ed59e1d1-2cff952d0d7mr8853704a91.30.1722829853348; Sun, 04 Aug 2024 20:50:53 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:fc55:48f9:5161:d744]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cfdc432b16sm9206199a91.21.2024.08.04.20.50.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Aug 2024 20:50:52 -0700 (PDT) In-Reply-To: <8F99C2F8-F88E-4662-B2E8-70592DBAEAC8@gmail.com> X-Mailer: Apple Mail (2.3774.600.62) Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=casouri@gmail.com; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322349 Archived-At: > On Aug 3, 2024, at 12:30=E2=80=AFAM, Yuan Fu = wrote: >=20 >=20 >=20 >> On Aug 1, 2024, at 1:53=E2=80=AFAM, Andrea Corallo = wrote: >>=20 >> Yuan Fu writes: >>=20 >>> branch: master >>> commit 74bb1e5897f4532fbdefddada28258a8d3d5c95f >>> Author: Yuan Fu >>> Commit: Yuan Fu >>>=20 >>> Fix filling in c-ts-mode (bug#72116) >>>=20 >>> The previous fix introduced a regression in the case when there's = only a >>> single line in the block comment. In that case we don't want to = add a >>> start at the second line: >>>=20 >>> /* foo foo foo */ should =3D> /* foo foo >>> foo */ >>>=20 >>> rather than /* foo foo >>> * foo */ >>>=20 >>> This commit fixes that. >>>=20 >>> * lisp/progmodes/c-ts-common.el: >>> (c-ts-common--fill-block-comment): Don't mask the /*. >>> (c-ts-common--adaptive-fill-prefix): New function. >>> (c-ts-common-comment-setup): Don't set adaptive-regexp, change >>> adaptive-fill-first-line-regexp to work with the new >>> adaptive-fill-function. >>> * test/lisp/progmodes/c-ts-mode-resources/filling.erts: New tests >>=20 >> Hi Yuan, >>=20 >> this change is causing the following regression on my testbench on >> master: >>=20 >> c-ts-mode-test-filling >> 1/4 c-ts-mode-test-filling (0.015896 sec) at = lisp/progmodes/c-ts-mode-tests.el:38 >>=20 >> Would you mind having a look? >>=20 >> Thanks >=20 > Yes absolutely, wonder why it didn=E2=80=99t error when I wrote the = patch :-( Ok, should be fixed now. Yuan