From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: log-edit.el Date: Thu, 26 May 2005 19:14:45 +1200 Message-ID: <17045.30566.3446.692950@farnswood.snap.net.nz> References: <17044.23349.76511.530320@farnswood.snap.net.nz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1117091652 6358 80.91.229.2 (26 May 2005 07:14:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 26 May 2005 07:14:12 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 26 09:14:10 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DbCYT-0004FV-Cw for ged-emacs-devel@m.gmane.org; Thu, 26 May 2005 09:13:22 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DbCcU-0000lc-HS for ged-emacs-devel@m.gmane.org; Thu, 26 May 2005 03:17:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DbCbE-0000Bt-0h for emacs-devel@gnu.org; Thu, 26 May 2005 03:16:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DbCbC-0000B6-J5 for emacs-devel@gnu.org; Thu, 26 May 2005 03:16:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DbCbC-0000Aw-E1 for emacs-devel@gnu.org; Thu, 26 May 2005 03:16:10 -0400 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DbCZ5-0006vQ-SA; Thu, 26 May 2005 03:14:00 -0400 Original-Received: from farnswood.snap.net.nz (p54-tnt1.snap.net.nz [202.124.110.54]) by viper.snap.net.nz (Postfix) with ESMTP id B91D35377D2; Thu, 26 May 2005 19:13:22 +1200 (NZST) Original-Received: by farnswood.snap.net.nz (Postfix, from userid 501) id B452062A99; Thu, 26 May 2005 08:14:46 +0100 (BST) Original-To: rms@gnu.org In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.0.50.61 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37682 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37682 Richard Stallman writes: > (dolist (file files) > ! ;; Prefix filename with a space to distinguish e.g fns.c xfns.c. > ! (let* ((entries (log-edit-changelog-entries (concat " " file))) > > This change is clearly the wrong way to do it. > The argument to log-edit-changelog-entries is supposed to be a file name. > If it doesn't work, you should fix it, not enshrine the error > by passing an arg that is not a file name. Yes. But it did motivate Stefan to provide a proper patch. Nick