From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: Forward button in help buffer Date: Wed, 18 May 2005 14:42:59 +1200 Message-ID: <17034.43955.796719.313790@farnswood.snap.net.nz> References: <17033.32714.752829.223651@farnswood.snap.net.nz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1116422967 9710 80.91.229.2 (18 May 2005 13:29:27 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 18 May 2005 13:29:27 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 18 15:29:22 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DYOa4-0001Va-Lr for ged-emacs-devel@m.gmane.org; Wed, 18 May 2005 15:27:24 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DYOcU-0001hR-In for ged-emacs-devel@m.gmane.org; Wed, 18 May 2005 09:29:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DYEt5-0002m7-C2 for emacs-devel@gnu.org; Tue, 17 May 2005 23:06:23 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DYEt3-0002l1-WF for emacs-devel@gnu.org; Tue, 17 May 2005 23:06:22 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DYEqy-00016n-SB for emacs-devel@gnu.org; Tue, 17 May 2005 23:04:14 -0400 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DYEe5-0005y7-6K; Tue, 17 May 2005 22:50:54 -0400 Original-Received: from farnswood.snap.net.nz (p248-tnt2.snap.net.nz [202.124.108.248]) by viper.snap.net.nz (Postfix) with ESMTP id D8C484BCC67; Wed, 18 May 2005 14:42:28 +1200 (NZST) Original-Received: by farnswood.snap.net.nz (Postfix, from userid 501) id 7162262A99; Wed, 18 May 2005 03:43:00 +0100 (BST) Original-To: rms@gnu.org In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.0.50.49 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37250 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37250 > I think this is simply a new feature, not fixing a problem. Sure, just like Unicode is a new feature. > Emacs is not incomplete or broken without it. Navigating the help buffer without a forward button is tedious. This is a small patch. > So please save it for after the next release. You've just said that we're not close to being ready. Then presumably there will be an extensive pretest period. I can't begin to imagine how far away the "next release" is. > But thanks for implementing it. Please do install it once > the release is out. Its your choice. I know from experience you won't change your mind, so how about these two changes: 1) A back button when describe-face is called from list-faces-display to take it back to the list of faces. 2) Removing hyperlinking in a variable's value. These are quite frequently inappropriate e.g C-h v features , C-h v gud-minor-mode Nick *** /home/nick/emacs/lisp/faces.el.~1.306.~ 2005-05-16 23:57:10.000000000 +1200 --- /home/nick/emacs/lisp/faces.el 2005-05-18 11:11:16.000000000 +1200 *************** *** 1184,1189 **** --- 1184,1190 ---- (save-excursion (save-match-data (search-backward face-name) + (setq help-xref-stack-item '(list-faces-display)) (help-xref-button 0 'help-customize-face face))) (let ((beg (point)) (line-beg (line-beginning-position))) diff -c /home/nick/emacs/lisp/help-fns.el.\~1.66.\~ /home/nick/emacs/lisp/help-fns.el *** /home/nick/emacs/lisp/help-fns.el.~1.66.~ 2005-03-31 17:28:17.000000000 +1200 --- /home/nick/emacs/lisp/help-fns.el 2005-05-17 23:15:24.000000000 +1200 *************** *** 535,541 **** (terpri) (let ((from (point))) (pp val) ! (help-xref-on-pp from (point)) (if (< (point) (+ from 20)) (delete-region (1- from) from))))) (terpri) --- 535,541 ---- (terpri) (let ((from (point))) (pp val) ! ; (help-xref-on-pp from (point)) (if (< (point) (+ from 20)) (delete-region (1- from) from))))) (terpri) *************** *** 556,562 **** ;; sensible size before prettyprinting. -- fx (let ((from (point))) (pp val) ! (help-xref-on-pp from (point)) (if (< (point) (+ from 20)) (delete-region (1- from) from)))))) (terpri)) --- 556,562 ---- ;; sensible size before prettyprinting. -- fx (let ((from (point))) (pp val) ! ; (help-xref-on-pp from (point)) (if (< (point) (+ from 20)) (delete-region (1- from) from)))))) (terpri))