Re: Forward button in help buffer

[Nick Roberts <nickrob@snap.net.nz>]

 > I think this is simply a new feature, not fixing a problem.

Sure, just like Unicode is a new feature.

 > Emacs is not incomplete or broken without it.

Navigating the help buffer without a forward button is tedious. This
is a small patch.

 > So please save it for after the next release.
 
You've just said that we're not close to being ready. Then presumably
there will be an extensive pretest period. I can't begin to imagine how
far away the "next release" is.

 > But thanks for implementing it.  Please do install it once
 > the release is out.

Its your choice. I know from experience you won't change your mind, so
how about these two changes:

1) A back button when describe-face is called from list-faces-display
   to take it back to the list of faces.

2) Removing hyperlinking in a variable's value. These are
   quite frequently inappropriate e.g C-h v <RET> features <RET>,
   C-h v <RET> gud-minor-mode <RET>


Nick


*** /home/nick/emacs/lisp/faces.el.~1.306.~	2005-05-16 23:57:10.000000000 +1200
--- /home/nick/emacs/lisp/faces.el	2005-05-18 11:11:16.000000000 +1200
***************
*** 1184,1189 ****
--- 1184,1190 ----
  	  (save-excursion
  	    (save-match-data
  	      (search-backward face-name)
+ 	      (setq help-xref-stack-item '(list-faces-display))
  	      (help-xref-button 0 'help-customize-face face)))
  	  (let ((beg (point))
  		(line-beg (line-beginning-position)))


diff -c /home/nick/emacs/lisp/help-fns.el.\~1.66.\~ /home/nick/emacs/lisp/help-fns.el
*** /home/nick/emacs/lisp/help-fns.el.~1.66.~	2005-03-31 17:28:17.000000000 +1200
--- /home/nick/emacs/lisp/help-fns.el	2005-05-17 23:15:24.000000000 +1200
***************
*** 535,541 ****
  		(terpri)
  		(let ((from (point)))
  		  (pp val)
! 		  (help-xref-on-pp from (point))
  		  (if (< (point) (+ from 20))
  		      (delete-region (1- from) from)))))
  	    (terpri)
--- 535,541 ----
  		(terpri)
  		(let ((from (point)))
  		  (pp val)
! ;		  (help-xref-on-pp from (point))
  		  (if (< (point) (+ from 20))
  		      (delete-region (1- from) from)))))
  	    (terpri)
***************
*** 556,562 ****
  		    ;; sensible size before prettyprinting.  -- fx
  		    (let ((from (point)))
  		      (pp val)
! 		      (help-xref-on-pp from (point))
  		      (if (< (point) (+ from 20))
  			(delete-region (1- from) from))))))
  	      (terpri))
--- 556,562 ----
  		    ;; sensible size before prettyprinting.  -- fx
  		    (let ((from (point)))
  		      (pp val)
! ;		      (help-xref-on-pp from (point))
  		      (if (< (point) (+ from 20))
  			(delete-region (1- from) from))))))
  	      (terpri))