From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: Overlay arrow in *compilation* and *grep* buffers Date: Sun, 8 May 2005 12:41:49 +1200 Message-ID: <17021.24653.326104.756208@farnswood.snap.net.nz> References: <01c548ba$Blat.v2.4$e4827900@zahav.net.il> <01c54909$Blat.v2.4$070f3e60@zahav.net.il> <01c55320$Blat.v2.4$c3c8c1e0@zahav.net.il> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1115512903 16601 80.91.229.2 (8 May 2005 00:41:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 8 May 2005 00:41:43 +0000 (UTC) Cc: Eli Zaretskii , rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 08 02:41:41 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DUZrR-0007sv-Aa for ged-emacs-devel@m.gmane.org; Sun, 08 May 2005 02:41:33 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DUZzS-00060F-LN for ged-emacs-devel@m.gmane.org; Sat, 07 May 2005 20:49:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DUZxr-0004mS-Fh for emacs-devel@gnu.org; Sat, 07 May 2005 20:48:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DUZxq-0004m1-Fr for emacs-devel@gnu.org; Sat, 07 May 2005 20:48:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DUZvj-0003tD-5L for emacs-devel@gnu.org; Sat, 07 May 2005 20:45:59 -0400 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DUZx8-00078C-1k; Sat, 07 May 2005 20:47:26 -0400 Original-Received: from farnswood.snap.net.nz (p242-tnt2.snap.net.nz [202.124.108.242]) by viper.snap.net.nz (Postfix) with ESMTP id A4A474DE08C; Sun, 8 May 2005 12:41:35 +1200 (NZST) Original-Received: by farnswood.snap.net.nz (Postfix, from userid 501) id 5036562A99; Sun, 8 May 2005 01:41:49 +0100 (BST) Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.0.50.40 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:36843 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36843 > >> Why not do what was suggested? > >> > >> (unless (display-graphic-p) > >> (put 'next-error-overlay-arrow-position 'overlay-arrow-string "")) > > > > Since no one objected, I fixed it like this, but a little bit > > differently: I set overlay-error-string to "" in compilation-setup, if > > the terminal is not graphic. The thread moved on from there. You (= Eli) have done: (set (make-local-variable 'overlay-arrow-string) (if (display-graphic-p) "=>" "")) I said that the condition (if (display-graphic-p)... was unnecessary and unrequired. On a graphical display, when there is a left hand fringe overlay-arrow-string isn't used and when there isn't one, you presumably want overlay-arrow-string to be "=>". > IIRC, Richard installed the above change already. Maybe that wasn't > necessary? Richard installed a different change to simple.el. (put 'next-error-overlay-arrow-position 'overlay-arrow-string "") but this is a *different* arrow that displays in the *source* buffer. I think this change is wrong. I suggested a patch in this thread (Sat, 30 Apr 2005 00:19:43 +1200) which also moves the current error to the top for the current error. Nick