From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: buffer.c/buffer.h: How to add new buffer-local variables? Date: Mon, 8 Apr 2019 16:06:07 -0700 Organization: UCLA Computer Science Department Message-ID: <16aa8fe9-82dc-c3f6-dbb5-1027ef8ae796@cs.ucla.edu> References: <3C6817C0-1CDB-4F83-805E-BF6B93C77F44@gnu.org> <87y34kl7y5.fsf@igel.home> <831s2c8kav.fsf@gnu.org> <5d4bef90-0fdc-31e2-0543-a322cdc4eea4@cs.ucla.edu> <87ef6cywbp.fsf@md5i.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="114034"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 To: Michael Welsh Duggan , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 09 01:06:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDdLH-000TQ6-R0 for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 01:06:19 +0200 Original-Received: from localhost ([127.0.0.1]:60237 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDdLG-0001lp-Sh for ged-emacs-devel@m.gmane.org; Mon, 08 Apr 2019 19:06:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDdLA-0001lh-8L for emacs-devel@gnu.org; Mon, 08 Apr 2019 19:06:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDdL9-0001wd-9d for emacs-devel@gnu.org; Mon, 08 Apr 2019 19:06:12 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39004) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDdL8-0001tn-U1 for emacs-devel@gnu.org; Mon, 08 Apr 2019 19:06:11 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B84EB160FDA; Mon, 8 Apr 2019 16:06:08 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id iinGKKQSlmtc; Mon, 8 Apr 2019 16:06:08 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 055381616AC; Mon, 8 Apr 2019 16:06:08 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WJvbiflIXPpD; Mon, 8 Apr 2019 16:06:07 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id DB3A216169E; Mon, 8 Apr 2019 16:06:07 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <87ef6cywbp.fsf@md5i.com> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235139 Archived-At: On 4/8/19 3:19 PM, Michael Welsh Duggan wrote: > I would also add a comment after the > cursor_in_non_selected_windows_ entry to the effect that the define > needs to be updated if more are added afterward. There's already a comment there to that effect, and similar comments near similar boundaries in other structures. A patch to regularize and/or clarify them would be welcome. Not sure I want to add a macro, though, as it's one more thing to maintain and it's not clear it's worth the hassle since one can get the macro wrong too. (What I'd prefer is a static check of the rule, without any macros.)