From: Dmitry Gutov <dgutov@yandex.ru>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Overriding the value of indent-tabs-mode in Emacs code
Date: Thu, 26 May 2016 01:18:24 +0300 [thread overview]
Message-ID: <16a64a9c-4053-9a49-01db-e3f2ea03fd0e@yandex.ru> (raw)
In-Reply-To: <b6903832-66f8-e000-d69b-0198cac650ee@cs.ucla.edu>
On 05/26/2016 01:11 AM, Paul Eggert wrote:
> In this particular case, the existing code uses tabs for indentation. So
> it is puzzling that you'd be troubled by a patch that sticks with that
> convention. Here, switching to all-spaces would make the patch harder to
> read.
I'm troubled by you overriding the project's convention. If you do it
here, you must do it in other cases as well.
And the function in question contains both conventions already.
>> We're not "switching" to all-spaces.
> Yes, that's what I thought.
"Switching" implies we've had a single, different convention before.
next prev parent reply other threads:[~2016-05-25 22:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87bn3z4l9i.fsf@mat.ucm.es>
[not found] ` <1444321464004323@web25h.yandex.ru>
[not found] ` <83h9do67pp.fsf@gnu.org>
[not found] ` <21f6198c-a2fc-365f-caf7-79fad5027f1c@yandex.ru>
[not found] ` <32b48032-8b30-d1d4-259c-8715aad3e7b8@cs.ucla.edu>
[not found] ` <86c6d05c-a37f-e223-d0d2-af63d09ed0cc@yandex.ru>
[not found] ` <be0c3f50-de71-e99d-08b0-7ecf17842b74@cs.ucla.edu>
[not found] ` <ea7c15a3-18eb-881d-821c-c350a64f9848@yandex.ru>
[not found] ` <57454B75.6070506@cs.ucla.edu>
2016-05-25 12:48 ` Overriding the value of indent-tabs-mode in Emacs code Dmitry Gutov
2016-05-25 21:44 ` Paul Eggert
2016-05-25 22:00 ` Dmitry Gutov
2016-05-25 22:11 ` Paul Eggert
2016-05-25 22:18 ` Dmitry Gutov [this message]
2016-05-25 22:36 ` Paul Eggert
2016-05-25 22:47 ` Dmitry Gutov
2016-05-25 23:24 ` Michael Heerdegen
2016-05-25 23:30 ` Dmitry Gutov
2016-05-25 23:54 ` Stefan Monnier
2016-05-26 10:59 ` Dmitry Gutov
2016-05-26 12:18 ` Stefan Monnier
2016-05-27 19:45 ` John Wiegley
2016-05-27 19:50 ` Stefan Monnier
2016-05-27 20:19 ` Paul Eggert
2016-05-27 20:53 ` John Wiegley
2016-05-26 0:00 ` Michael Heerdegen
2016-05-25 23:40 ` Karl Fogel
2016-05-26 0:02 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16a64a9c-4053-9a49-01db-e3f2ea03fd0e@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).