unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* `xterm-mouse-mode' has a bogus Custom group
@ 2005-04-02  3:51 Luc Teirlinck
  2005-04-02  5:30 ` Nick Roberts
  0 siblings, 1 reply; 73+ messages in thread
From: Luc Teirlinck @ 2005-04-02  3:51 UTC (permalink / raw)


`xterm-mouse-mode' relies on a bogus default :group, chosen by
define-minor-mode, xterm-mouse, that does not have one of the major
groups as an ancestor (in fact, that does not even have a parent
group).  As a result, users can never find it while browsing Custom
using `customize-browse' or similar.  This is bad, since it is an
option many people who have to often run Emacs in an xterm might want
to set.

I believe that we have to choose a valid group for `xterm-mouse-mode'.
Maybe the most logical is 'mouse, as the patch below implements.

Another frustration I had with `xterm-mouse-mode' was finding
appropriate documentation starting from the Custom buffer.

In the Custom buffer, you get the documentation for the variable,
which simply says to read the docstring of the function instead:

See the command `xterm-mouse-mode' for a description of this minor-mode.

If you click on that link, you do not get the doc for the function
yet, but a buffer telling you once more that `xterm-mouse-mode' is
both a variable and a command and also has a plist.  You have to click
on `Command:".  Then we finally get the function docstring, which
barely says anything of substance either.

Everything but the last fact applies to just about any minor mode
defined by define-minor-mode.  The only thing the patch below does
something about is the last fact: it expands the command docstring.
(Most of the new text is based on the Emacs manual documentation.)

I can install the patch below if desired.

===File ~/xt-mouse-diff=====================================
*** xt-mouse.el	17 Jan 2005 10:30:26 -0600	1.24
--- xt-mouse.el	01 Apr 2005 20:55:39 -0600	
***************
*** 155,162 ****
    "Toggle XTerm mouse mode.
  With prefix arg, turn XTerm mouse mode on iff arg is positive.
  
! Turn it on to use emacs mouse commands, and off to use xterm mouse commands."
!   nil " Mouse" nil :global t
    (if xterm-mouse-mode
        ;; Turn it on
        (unless window-system
--- 155,167 ----
    "Toggle XTerm mouse mode.
  With prefix arg, turn XTerm mouse mode on iff arg is positive.
  
! Turn it on to use emacs mouse commands, and off to use xterm mouse commands.
! This works in terminal emulators compatible with xterm.  Only single clicks
! are supported.  When turned on, the normal xterm mouse functionality is still
! available by holding down the SHIFT key while pressing the mouse button.
! The Linux console supports this mode if it has support for the mouse enabled,
! for instance using the gpm daemon."
!   nil " Mouse" nil :global t :group 'mouse
    (if xterm-mouse-mode
        ;; Turn it on
        (unless window-system
============================================================

^ permalink raw reply	[flat|nested] 73+ messages in thread

end of thread, other threads:[~2005-04-16  1:06 UTC | newest]

Thread overview: 73+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-02  3:51 `xterm-mouse-mode' has a bogus Custom group Luc Teirlinck
2005-04-02  5:30 ` Nick Roberts
2005-04-02 13:46   ` Luc Teirlinck
2005-04-05  6:25     ` Nick Roberts
2005-04-06  0:00       ` Luc Teirlinck
2005-04-06  0:17         ` David Kastrup
2005-04-06 23:01           ` Richard Stallman
2005-04-06 23:22             ` David Kastrup
2005-04-07  8:44               ` Kim F. Storm
2005-04-07  9:21                 ` Han Boetes
2005-04-07  9:29                 ` Nick Roberts
2005-04-08  3:22                   ` Richard Stallman
2005-04-07  9:30                 ` David Kastrup
2005-04-08  3:22               ` Richard Stallman
2005-04-08  8:13                 ` David Kastrup
2005-04-06  2:59         ` Nick Roberts
2005-04-07  0:45           ` Luc Teirlinck
2005-04-08  1:50             ` Nick Roberts
2005-04-08  1:59               ` Luc Teirlinck
2005-04-08  2:13                 ` Nick Roberts
2005-04-08 15:14                   ` Andreas Schwab
2005-04-08  2:22                 ` Nick Roberts
2005-04-08 14:32               ` Richard Stallman
2005-04-08 16:05                 ` Luc Teirlinck
2005-04-08 21:54                   ` Nick Roberts
2005-04-09  0:28                     ` Luc Teirlinck
2005-04-09  4:06                     ` Luc Teirlinck
2005-04-09  5:22                       ` Nick Roberts
2005-04-09  7:53                         ` Eli Zaretskii
2005-04-09 11:04                           ` Nick Roberts
2005-04-09 15:37                             ` Luc Teirlinck
2005-04-09 22:21                               ` Nick Roberts
2005-04-10  1:54                         ` Richard Stallman
2005-04-10  1:54                       ` Richard Stallman
2005-04-10  4:54                         ` Eli Zaretskii
2005-04-10 13:18                           ` Luc Teirlinck
2005-04-10 14:37                             ` Stefan Monnier
2005-04-10 15:29                               ` Luc Teirlinck
2005-04-10 21:51                               ` Nick Roberts
2005-04-10 23:30                                 ` Luc Teirlinck
2005-04-13  5:02                                 ` Richard Stallman
2005-04-13 10:21                                   ` David Kastrup
2005-04-11  1:56                             ` Richard Stallman
2005-04-12  1:04                               ` Luc Teirlinck
2005-04-12  1:28                                 ` Luc Teirlinck
2005-04-12 17:25                                 ` Richard Stallman
2005-04-13  1:24                                   ` Luc Teirlinck
2005-04-13  4:58                                     ` Jan D.
2005-04-13  5:28                                       ` Eli Zaretskii
2005-04-14  2:16                                         ` Luc Teirlinck
2005-04-14  4:06                                           ` Eli Zaretskii
2005-04-14  7:40                                           ` Kim F. Storm
2005-04-15  2:04                                             ` Luc Teirlinck
2005-04-15  8:23                                               ` Miles Bader
2005-04-15  8:47                                                 ` Ismail Donmez
2005-04-15  8:47                                               ` Kim F. Storm
2005-04-15  9:07                                               ` Eli Zaretskii
2005-04-16  1:06                                                 ` Luc Teirlinck
2005-04-14 19:03                                           ` Richard Stallman
2005-04-15  2:11                                             ` Luc Teirlinck
2005-04-13  5:21                                     ` Eli Zaretskii
2005-04-12  2:12                               ` Luc Teirlinck
2005-04-12  2:47                                 ` Luc Teirlinck
2005-04-12 17:23                                 ` Richard Stallman
2005-04-13  0:01                                   ` Luc Teirlinck
2005-04-12 23:31                                     ` David Kastrup
2005-04-13  1:49                                       ` Luc Teirlinck
2005-04-13  2:17                                     ` Stefan Monnier
2005-04-13 18:31                                     ` Richard Stallman
2005-04-10 14:27                         ` Stefan Monnier
2005-04-11  1:56                           ` Richard Stallman
2005-04-06  3:02       ` Richard Stallman
2005-04-06  8:22         ` David Kastrup

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).