From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: isearch-forward and Info-search Date: Mon, 14 Mar 2005 10:15:18 +1300 Message-ID: <16948.44390.631597.385892@farnswood.snap.net.nz> References: <16942.42643.503788.488893@farnswood.snap.net.nz> <87vf7xr1gm.fsf@jurta.org> <87mzt9f05i.fsf-monnier+emacs@gnu.org> <878y4sjlme.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1110749818 30492 80.91.229.2 (13 Mar 2005 21:36:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 13 Mar 2005 21:36:58 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 13 22:36:57 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DAakV-00007E-E4 for ged-emacs-devel@m.gmane.org; Sun, 13 Mar 2005 22:35:47 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DAb03-0008UY-Rx for ged-emacs-devel@m.gmane.org; Sun, 13 Mar 2005 16:51:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DAawQ-0006uZ-8k for emacs-devel@gnu.org; Sun, 13 Mar 2005 16:48:06 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DAawL-0006rR-9l for emacs-devel@gnu.org; Sun, 13 Mar 2005 16:48:02 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DAawJ-0006m1-Tb for emacs-devel@gnu.org; Sun, 13 Mar 2005 16:48:00 -0500 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DAaRm-0005O4-Fk for emacs-devel@gnu.org; Sun, 13 Mar 2005 16:16:26 -0500 Original-Received: from farnswood.snap.net.nz (p37-tnt2.snap.net.nz [202.124.108.37]) by viper.snap.net.nz (Postfix) with ESMTP id CFF72498D2B; Mon, 14 Mar 2005 10:16:24 +1300 (NZDT) Original-Received: by farnswood.snap.net.nz (Postfix, from userid 501) id ABDD362FBE; Sun, 13 Mar 2005 21:15:19 +0000 (GMT) Original-To: Juri Linkov In-Reply-To: <878y4sjlme.fsf@jurta.org> X-Mailer: VM 7.19 under Emacs 22.0.50.11 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34553 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34553 > > The implementation looks clean. I just suggest that we should simply > > replace isearch-invalid-regexp with isearch-error (there can only be one > > error at any given time, either a search failure or an invalid regexp, or > > ...). > > OK. > > I also removed `isearch-within-brackets' because it is used nowhere > within Emacs. And added `condition-case' around the call to > `isearch-search-fun' in `isearch-lazy-highlight-search' to return nil > in case of error which allows `isearch-lazy-highlight-update' to try to > highlight matches from the window beginning (needed for Info isearch). I like the way this works. Thanks for fixing it. Nick