From: Nick Roberts <nickrob@snap.net.nz>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: isearch-forward and Info-search
Date: Mon, 14 Mar 2005 10:15:18 +1300 [thread overview]
Message-ID: <16948.44390.631597.385892@farnswood.snap.net.nz> (raw)
In-Reply-To: <878y4sjlme.fsf@jurta.org>
> > The implementation looks clean. I just suggest that we should simply
> > replace isearch-invalid-regexp with isearch-error (there can only be one
> > error at any given time, either a search failure or an invalid regexp, or
> > ...).
>
> OK.
>
> I also removed `isearch-within-brackets' because it is used nowhere
> within Emacs. And added `condition-case' around the call to
> `isearch-search-fun' in `isearch-lazy-highlight-search' to return nil
> in case of error which allows `isearch-lazy-highlight-update' to try to
> highlight matches from the window beginning (needed for Info isearch).
I like the way this works. Thanks for fixing it.
Nick
next prev parent reply other threads:[~2005-03-13 21:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-09 7:32 isearch-forward and Info-search Nick Roberts
2005-03-09 7:59 ` Miles Bader
2005-03-10 2:02 ` Richard Stallman
2005-03-10 6:29 ` Juri Linkov
2005-03-10 7:56 ` Nick Roberts
2005-03-10 17:20 ` Drew Adams
2005-03-11 1:48 ` Richard Stallman
2005-03-10 6:33 ` Juri Linkov
2005-03-10 17:19 ` Drew Adams
2005-03-11 7:28 ` Juri Linkov
2005-03-11 8:15 ` Nick Roberts
2005-03-11 14:40 ` Drew Adams
2005-03-12 2:23 ` Juri Linkov
2005-03-12 13:47 ` Stefan Monnier
2005-03-13 1:00 ` Juri Linkov
2005-03-13 21:15 ` Nick Roberts [this message]
2005-03-29 12:17 ` Kai Großjohann
2005-03-29 13:48 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16948.44390.631597.385892@farnswood.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).