From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stephen Eglen Newsgroups: gmane.emacs.devel Subject: VM and find-face Date: Thu, 6 Jan 2005 15:49:38 +0000 Message-ID: <16861.24082.521425.279155@notch.amtp.cam.ac.uk> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1105027399 19180 80.91.229.6 (6 Jan 2005 16:03:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 6 Jan 2005 16:03:19 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 06 17:03:09 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Cma6P-00007i-00 for ; Thu, 06 Jan 2005 17:03:09 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CmaHi-0004uw-D8 for ged-emacs-devel@m.gmane.org; Thu, 06 Jan 2005 11:14:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CmaGS-0004EB-0q for emacs-devel@gnu.org; Thu, 06 Jan 2005 11:13:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CmaGQ-0004Da-KF for emacs-devel@gnu.org; Thu, 06 Jan 2005 11:13:31 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CmaGQ-0004DU-8u for emacs-devel@gnu.org; Thu, 06 Jan 2005 11:13:30 -0500 Original-Received: from [131.111.8.132] (helo=ppsw-2.csi.cam.ac.uk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CmZtV-0002yM-KM for emacs-devel@gnu.org; Thu, 06 Jan 2005 10:49:49 -0500 Original-Received: from smtp.damtp.cam.ac.uk ([131.111.18.84]:39440 helo=medulla.damtp.cam.ac.uk) by ppsw-2.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.132]:25) with esmtp id 1CmZtO-0002c8-8j (Exim 4.44) for emacs-devel@gnu.org (return-path ); Thu, 06 Jan 2005 15:49:42 +0000 Original-Received: from notch.amtp.cam.ac.uk ([131.111.16.112] ident=[UZr5NSidB7V2OeOK2gK3n3F30md473yQ]) by medulla.damtp.cam.ac.uk with esmtp (Exim 4.32) id 1CmZtL-00025B-Tm; Thu, 06 Jan 2005 15:49:39 +0000 Original-Received: from sje30 by notch.amtp.cam.ac.uk with local (Exim 4.12) id 1CmZtL-0003dB-00; Thu, 06 Jan 2005 15:49:39 +0000 Original-To: emacs-devel@gnu.org, kyle_jones@wonderworks.com X-Mailer: VM 7.17 under Emacs 21.3.50.1 X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ X-Cam-AntiVirus: No virus found X-Cam-SpamDetails: Not scanned X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:31956 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:31956 Hi, VM 7.17 no longer works with the CVS version of Emacs, I think due to the introduction yesterday of find-face into find-func.el. VM has the following code: (if (if (fboundp 'find-face) (find-face 'vm-monochrome-image) (facep 'vm-monochrome-image)) nil (make-face 'vm-monochrome-image) (set-face-background 'vm-monochrome-image "white") (set-face-foreground 'vm-monochrome-image "black")) In todays's CVS emacs, with its newly defined find-face defun, I get the backtrace: signal(error ("Don't know where `vm-monochrome-image' is defined")) error("Don't know where `%s' is defined" vm-monochrome-image) find-function-search-for-symbol(vm-monochrome-image defface nil) find-definition-noselect(vm-monochrome-image defface) find-function-do-it(vm-monochrome-image defface switch-to-buffer) find-face(vm-monochrome-image) One problem is that find-face behaves differently on Emacs and XEmacs; find-face returns nil on the above call if the face could not be found. What's the best way to proceed - update VM or allow find-face to return nil? Stephen