* restore comint-dynamic-complete-functions as a local variable
@ 2004-11-06 17:12 Stephen Eglen
2004-11-08 14:57 ` Stefan
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Eglen @ 2004-11-06 17:12 UTC (permalink / raw)
Hi,
In Emacs 21.2, comint-dynamic-complete-functions was set to be
buffer-local using:
(make-local-hook 'comint-dynamic-complete-functions)
In Emacs CVS this is no longer the case, since make-local-hook is
obsolete. It is still documented (line 304 of comint.el) as a buffer
local variable, and yet it is no longer local. Is this just an
accidental omission, or something intentional? I'd suggest it be
buffer-local again - any objections?
The relevant change log entry is:
revision 1.251
date: 2001/11/16 14:22:03; author: monnier; state: Exp; lines: +6 -16
(comint-mode): Simplify.
(make-comint-in-buffer): Run `comint-mode' only if necessary.
Thanks, Stephen
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: restore comint-dynamic-complete-functions as a local variable
2004-11-06 17:12 restore comint-dynamic-complete-functions as a local variable Stephen Eglen
@ 2004-11-08 14:57 ` Stefan
0 siblings, 0 replies; 2+ messages in thread
From: Stefan @ 2004-11-08 14:57 UTC (permalink / raw)
Cc: emacs-devel
> In Emacs 21.2, comint-dynamic-complete-functions was set to be
> buffer-local using:
> (make-local-hook 'comint-dynamic-complete-functions)
> In Emacs CVS this is no longer the case, since make-local-hook is
> obsolete. It is still documented (line 304 of comint.el) as a buffer
> local variable, and yet it is no longer local. Is this just an
> accidental omission, or something intentional? I'd suggest it be
> buffer-local again - any objections?
What does it mean for it to be "buffer-local"?
Does anyone incorrectly set it with `setq' rather than `add-hook'?
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-08 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-06 17:12 restore comint-dynamic-complete-functions as a local variable Stephen Eglen
2004-11-08 14:57 ` Stefan
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).