From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: font-lock in machine mode of gdba Date: Wed, 20 Oct 2004 02:28:37 +1300 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: <16757.5765.225553.503676@farnswood.snap.net.nz> References: <20041018.002930.45492341.jet@gyve.org> <16755.10649.857644.666785@farnswood.snap.net.nz> <20041019.112647.212948122.jet@gyve.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1098193169 8432 80.91.229.6 (19 Oct 2004 13:39:29 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 19 Oct 2004 13:39:29 +0000 (UTC) Cc: nickrob@snap.net.nz, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 19 15:39:21 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CJuCu-0004Uh-00 for ; Tue, 19 Oct 2004 15:39:21 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CJuKF-00005r-MM for ged-emacs-devel@m.gmane.org; Tue, 19 Oct 2004 09:46:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CJuK1-0008Uj-9Q for emacs-devel@gnu.org; Tue, 19 Oct 2004 09:46:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CJuJv-0008Rk-7Q for emacs-devel@gnu.org; Tue, 19 Oct 2004 09:46:36 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CJuJr-0008Ot-L9 for emacs-devel@gnu.org; Tue, 19 Oct 2004 09:46:32 -0400 Original-Received: from [199.232.41.8] (helo=mx20.gnu.org) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1CJuBm-0007YA-Gy for emacs-devel@gnu.org; Tue, 19 Oct 2004 09:38:10 -0400 Original-Received: from [202.124.110.49] (helo=farnswood.snap.net.nz) by mx20.gnu.org with esmtp (Exim 4.34) id 1CJu88-0006JP-4Z for emacs-devel@gnu.org; Tue, 19 Oct 2004 09:34:24 -0400 Original-Received: by farnswood.snap.net.nz (Postfix, from userid 501) id CD79862FA1; Tue, 19 Oct 2004 14:28:37 +0100 (BST) Original-To: Masatake YAMATO In-Reply-To: <20041019.112647.212948122.jet@gyve.org> X-Mailer: VM 6.97 under Emacs 21.2.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:28603 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:28603 > > I think it should at least be consistent with asm-mode where keywords like > > movl, andl, etc are fontified with font-lock-keyword-face and operands and > > registers are left unfontified. > > I have changed both gdb-ui.el and asm-mode.el; and used the same face in the > both mode for the same object. Do you think operand fontification is too decorative? > > Now font-lock-mode is turn-on in gdb-assembler-mode when global-font-lock-mode is > true. gdb-assembler-mode-hook is also provided. See the comments at the tail of > font-core.el. I don't know if the operand fontification too decorative but is it logical? Should a register name have font-lock-variable-face and an address font-lock-constant-face? I don't use disassembly for debugging or code in assembler. Perhaps someone who does can comment. Would gdb-assembler-mode-hook ever be used? Nick