From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Eric Gillespie Newsgroups: gmane.emacs.devel Subject: Re: GTK patches part 2 Date: Tue, 10 Dec 2002 16:23:59 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <16731.1039555439@remus.pretzelnet.org> References: <200212102040.gBAKe116016464@stubby.bodenonline.com> NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1039555747 27904 80.91.224.249 (10 Dec 2002 21:29:07 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 10 Dec 2002 21:29:07 +0000 (UTC) Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18Lrw7-0007Fb-00 for ; Tue, 10 Dec 2002 22:29:03 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18Ls6r-0004ar-00 for ; Tue, 10 Dec 2002 22:40:09 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18Lrrd-0006BV-01 for emacs-devel@quimby.gnus.org; Tue, 10 Dec 2002 16:24:25 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18LrrK-0006Ab-00 for emacs-devel@gnu.org; Tue, 10 Dec 2002 16:24:06 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18LrrI-00069w-00 for emacs-devel@gnu.org; Tue, 10 Dec 2002 16:24:05 -0500 Original-Received: from remus.pretzelnet.org ([216.37.46.186]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18LrrH-00069J-00 for emacs-devel@gnu.org; Tue, 10 Dec 2002 16:24:03 -0500 Original-Received: from remus.pretzelnet.org (localhost [127.0.0.1]) by remus.pretzelnet.org (Postfix) with ESMTP id 0A5101A285 for ; Tue, 10 Dec 2002 16:24:00 -0500 (EST) Original-To: emacs-devel@gnu.org User-Agent: nmh/1.0.4+dev (i386-unknown-netbsdelf1.6) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10042 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10042 "Jan D." writes: > > You can't rely on that. If *you* make reference to symbols or > > macros, *you* need to include the appropriate header file, > > regardless of whether or not some other header you include also > > needs that header file. Sometimes people just dump all their > > There is no such requrement in the C standard, even if it makes > sense for some people. Who said anything about the standard? Standards have nothing to do with this. The fact is that if you don't include relevant headers yourself (having them in local header files such as config.h as you mention below counts as "yourself", of course), you cannot count on the declarations being available. Unless you only want the program to work on your system, of course (no, i'm not accusing you of that, i know it was a simple mistake :). > For example, stdlib.h is included by config.h, so it is clearly Whoops. When i noticed the stderr problem also noticed malloc being called with no stdlib.h. As i said, my preferred style would be to go ahead and explicitly include stdlib.h in gtkutil.c itself. But i don't get to make such decisions for emacs, nor do i want to; it works and that's all that matters to me. > redundant to do so elsewhere. I can put in stdio.h just for the > sake of portability. Thanks. Just out of curiosity, which header included stdio.h for you on your system? -- Eric Gillespie <*> epg@pretzelnet.org Build a fire for a man, and he'll be warm for a day. Set a man on fire, and he'll be warm for the rest of his life. -Terry Pratchett