Error building emacs-unicode-2 from CVS

unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed

* Error building emacs-unicode-2 from CVS
@ 2004-09-08 17:54 Jose E. Marchesi
  2004-09-09  4:39 ` Janusz S. Bień
  2004-09-12 23:14 ` Kenichi Handa
  0 siblings, 2 replies; 5+ messages in thread
From: Jose E. Marchesi @ 2004-09-08 17:54 UTC (permalink / raw)



Hi,


I get the following error on the `make bootstrap' while building the
`emacs-unicode-2' branch from CVS:


Wrote /home/jemarch/gnu/src/emacs/emacs-unicode-2/emacs/lisp/loaddefs.el
Loading ange-ftp (source)...

In toplevel form:
eshell/em-term.el:46:1:Error: Symbol's value as variable is void: 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Error building emacs-unicode-2 from CVS
  2004-09-08 17:54 Error building emacs-unicode-2 from CVS Jose E. Marchesi
@ 2004-09-09  4:39 ` Janusz S. Bień
  2004-09-09  8:25   ` Katsumi Yamaoka
  2004-09-12 23:14 ` Kenichi Handa
  1 sibling, 1 reply; 5+ messages in thread
From: Janusz S. Bień @ 2004-09-09  4:39 UTC (permalink / raw)
  Cc: emacs-devel

On Wed, 8 Sep 2004  "Jose E. Marchesi" <jemarch@gnu.org> wrote:

> Hi,
> 
> 
> I get the following error on the `make bootstrap' while building the
> `emacs-unicode-2' branch from CVS:
> 
> 
> Wrote /home/jemarch/gnu/src/emacs/emacs-unicode-2/emacs/lisp/loaddefs.el
> Loading ange-ftp (source)...

> 
> In toplevel form:
> eshell/em-term.el:46:1:Error: Symbol's value as variable is void: 

I reported the same problem on emacs-unicode list.

Regards

Janusz

On 07 Sep 2004  jsbien@mimuw.edu.pl (Janusz S. Bień) wrote:

> On 06 Sep 2004  jsbien@mimuw.edu.pl (Janusz S. Bień) wrote:
> 
> > `make bootstrap' just failed for me on Debian Sarge.
> 
> There is a message
> 
>         Loading ange-ftp (source)...
> 
> then after very long time
> 
>         In toplevel form:
>         eshell/em-term.el:46:1:Error: Symbol's value as variable is void:
> 
> where the value is some enormous binary rubbish.
> 
> Last lines of the output are
> 
>         make[1]: *** [compile] Error 1
>         make: *** [bootstrap] Error 2

-- 
                     ,   
dr hab. Janusz S. Bien, prof. UW -  Uniwersytet Warszawski (Katedra Lingwistyki Formalnej)
Prof. Janusz S. Bien - Warsaw Uniwersity (Chair of Formal Linguistics)
jsbien@mimuw.edu.pl, jsbien@uw.edu.pl, http://www.mimuw.edu.pl/~jsbien/, http://www.klf.uw.edu.pl

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Error building emacs-unicode-2 from CVS
  2004-09-09  4:39 ` Janusz S. Bień
@ 2004-09-09  8:25   ` Katsumi Yamaoka
  2004-09-09 13:48     ` Jose E. Marchesi
  0 siblings, 1 reply; 5+ messages in thread
From: Katsumi Yamaoka @ 2004-09-09  8:25 UTC (permalink / raw)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=iso-2022-jp-2, Size: 406 bytes --]

>>>>> In <87656okqcu.fsf@mimuw.edu.pl> Janusz S. Bie^[$(D+M^[(B wrote:

> On Wed, 8 Sep 2004  "Jose E. Marchesi" <jemarch@gnu.org> wrote:

>> In toplevel form:
>> eshell/em-term.el:46:1:Error: Symbol's value as variable is void: 

> I reported the same problem on emacs-unicode list.

I inserted `-*- coding: binary; -*-' in the first line of
lisp/term.el and made building of Emacs successful savagely. :-p

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Error building emacs-unicode-2 from CVS
  2004-09-09  8:25   ` Katsumi Yamaoka
@ 2004-09-09 13:48     ` Jose E. Marchesi
  0 siblings, 0 replies; 5+ messages in thread
From: Jose E. Marchesi @ 2004-09-09 13:48 UTC (permalink / raw)
  Cc: emacs-devel

    >>>>> In <87656okqcu.fsf@mimuw.edu.pl> Janusz S. Bie

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Error building emacs-unicode-2 from CVS
  2004-09-08 17:54 Error building emacs-unicode-2 from CVS Jose E. Marchesi
  2004-09-09  4:39 ` Janusz S. Bień
@ 2004-09-12 23:14 ` Kenichi Handa
  1 sibling, 0 replies; 5+ messages in thread
From: Kenichi Handa @ 2004-09-12 23:14 UTC (permalink / raw)
  Cc: emacs-unicode, emacs-devel

Sorry for the late response on this thread.

In article <16703.18275.260109.175662@gargle.gargle.HOWL>, "Jose E. Marchesi" <jemarch@gnu.org> writes:

> I get the following error on the `make bootstrap' while building the
> `emacs-unicode-2' branch from CVS:

> Wrote /home/jemarch/gnu/src/emacs/emacs-unicode-2/emacs/lisp/loaddefs.el
> Loading ange-ftp (source)...

> In toplevel form:
> eshell/em-term.el:46:1:Error: Symbol's value as variable is void: ...

The source of the bug is that utf-16 detector was too
greedy.  I've just fixed it.  The attached is the relevant
patch.  I'll commit it as soon as cvs start to work.

---
Ken'ichi HANDA
handa@m17n.org

2004-09-13  Kenichi Handa  <handa@m17n.org>

	* coding.c (detect_coding_utf_16): Don't set detect_info->found if
	BOM is not found.
	(detect_coding): Optimization for ISO-2022 when no 8-bit data is
	found.
	(detect_coding_system): Likewise.
	
*** coding.c	28 Apr 2004 22:03:43 +0900	1.289.2.36
--- coding.c	12 Sep 2004 21:41:00 +0900	
***************
*** 1418,1443 ****
      }
    else if (c1 >= 0 && c2 >= 0)
      {
-       unsigned char b1[256], b2[256];
-       int b1_variants = 1, b2_variants = 1;
-       int n;
- 
-       bzero (b1, 256), bzero (b2, 256);
-       b1[c1]++, b2[c2]++;
-       for (n = 0; n < 256 && src < src_end; n++)
- 	{
- 	  src_base = src;
- 	  ONE_MORE_BYTE (c1);
- 	  ONE_MORE_BYTE (c2);
- 	  if (c1 < 0 || c2 < 0)
- 	    break;
- 	  if (! b1[c1++]) b1_variants++;
- 	  if (! b2[c2++]) b2_variants++;
- 	}
-       if (b1_variants < b2_variants)
- 	detect_info->found |= CATEGORY_MASK_UTF_16_BE_NOSIG;
-       else
- 	detect_info->found |= CATEGORY_MASK_UTF_16_LE_NOSIG;      
        detect_info->rejected
  	|= (CATEGORY_MASK_UTF_16_BE | CATEGORY_MASK_UTF_16_LE);
      }
--- 1418,1423 ----
***************
*** 5421,5473 ****
    if (EQ (CODING_ATTR_TYPE (CODING_ID_ATTRS (coding->id)), Qundecided))
      {
        int c, i;
  
        for (i = 0, src = coding->source; src < src_end; i++, src++)
  	{
  	  c = *src;
! 	  if (c & 0x80 || (c < 0x20 && (c == ISO_CODE_ESC
! 					|| c == ISO_CODE_SI
! 					|| c == ISO_CODE_SO)))
  	    break;
  	}
        coding->head_ascii = src - (coding->source + coding->consumed);
  
!       if (coding->head_ascii < coding->src_bytes)
  	{
- 	  struct coding_detection_info detect_info;
  	  enum coding_category category;
  	  struct coding_system *this;
  
! 	  detect_info.checked = detect_info.found = detect_info.rejected = 0;
! 	  for (i = 0; i < coding_category_raw_text; i++)
! 	    {
! 	      category = coding_priorities[i];
! 	      this = coding_categories + category;
! 	      if (this->id < 0)
! 		{
! 		  /* No coding system of this category is defined.  */
! 		  detect_info.rejected |= (1 << category);
! 		}
! 	      else if (category >= coding_category_raw_text)
! 		continue;
! 	      else if (detect_info.checked & (1 << category))
! 		{
! 		  if (detect_info.found & (1 << category))
! 		    break;
! 		}
! 	      else if ((*(this->detector)) (coding, &detect_info)
! 		       && detect_info.found & (1 << category))
! 		{
! 		  if (category == coding_category_utf_16_auto)
! 		    {
! 		      if (detect_info.found & CATEGORY_MASK_UTF_16_LE)
! 			category = coding_category_utf_16_le;
! 		      else
! 			category = coding_category_utf_16_be;
! 		    }
  		  break;
! 		}
! 	    }
  	  if (i < coding_category_raw_text)
  	    setup_coding_system (CODING_ID_NAME (this->id), coding);
  	  else if (detect_info.rejected == CATEGORY_MASK_ANY)
--- 5401,5478 ----
    if (EQ (CODING_ATTR_TYPE (CODING_ID_ATTRS (coding->id)), Qundecided))
      {
        int c, i;
+       struct coding_detection_info detect_info;
  
+       detect_info.checked = detect_info.found = detect_info.rejected = 0;
        for (i = 0, src = coding->source; src < src_end; i++, src++)
  	{
  	  c = *src;
! 	  if (c & 0x80)
  	    break;
+ 	  if (c < 0x20
+ 	      && (c == ISO_CODE_ESC || c == ISO_CODE_SI || c == ISO_CODE_SO)
+ 	      && ! inhibit_iso_escape_detection
+ 	      && ! detect_info.checked)
+ 	    {
+ 	      coding->head_ascii = src - (coding->source + coding->consumed);
+ 	      if (detect_coding_iso_2022 (coding, &detect_info))
+ 		{
+ 		  /* We have scanned the whole data.  */
+ 		  if (! (detect_info.rejected & CATEGORY_MASK_ISO_7_ELSE))
+ 		    /* We didn't find an 8-bit code.  */
+ 		    src = src_end;
+ 		  break;
+ 		}
+ 	    }
  	}
        coding->head_ascii = src - (coding->source + coding->consumed);
  
!       if (coding->head_ascii == coding->src_bytes
! 	  || detect_info.found)
  	{
  	  enum coding_category category;
  	  struct coding_system *this;
  
! 	  if (coding->head_ascii == coding->src_bytes)
! 	    /* As all bytes are 7-bit, we can ignore non-ISO-2022 codings.  */
! 	    for (i = 0; i < coding_category_raw_text; i++)
! 	      {
! 		category = coding_priorities[i];
! 		this = coding_categories + category;
! 		if (detect_info.found & (1 << category))
  		  break;
! 	      }
! 	  else
! 	    for (i = 0; i < coding_category_raw_text; i++)
! 	      {
! 		category = coding_priorities[i];
! 		this = coding_categories + category;
! 		if (this->id < 0)
! 		  {
! 		    /* No coding system of this category is defined.  */
! 		    detect_info.rejected |= (1 << category);
! 		  }
! 		else if (category >= coding_category_raw_text)
! 		  continue;
! 		else if (detect_info.checked & (1 << category))
! 		  {
! 		    if (detect_info.found & (1 << category))
! 		      break;
! 		  }
! 		else if ((*(this->detector)) (coding, &detect_info)
! 			 && detect_info.found & (1 << category))
! 		  {
! 		    if (category == coding_category_utf_16_auto)
! 		      {
! 			if (detect_info.found & CATEGORY_MASK_UTF_16_LE)
! 			  category = coding_category_utf_16_le;
! 			else
! 			  category = coding_category_utf_16_be;
! 		      }
! 		    break;
! 		  }
! 	      }
! 	  
  	  if (i < coding_category_raw_text)
  	    setup_coding_system (CODING_ID_NAME (this->id), coding);
  	  else if (detect_info.rejected == CATEGORY_MASK_ANY)
***************
*** 7120,7168 ****
        for (i = 0; src < src_end; i++, src++)
  	{
  	  c = *src;
! 	  if (c & 0x80 || (c < 0x20 && (c == ISO_CODE_ESC
! 					|| c == ISO_CODE_SI
! 					|| c == ISO_CODE_SO)))
  	    break;
  	}
        coding.head_ascii = src - coding.source;
  
!       if (src < src_end)
! 	for (i = 0; i < coding_category_raw_text; i++)
! 	  {
! 	    category = coding_priorities[i];
! 	    this = coding_categories + category;
! 
! 	    if (this->id < 0)
! 	      {
! 		/* No coding system of this category is defined.  */
! 		detect_info.rejected |= (1 << category);
! 	      }
! 	    else if (category >= coding_category_raw_text)
! 	      continue;
! 	    else if (detect_info.checked & (1 << category))
  	      {
! 		if (highest
! 		    && (detect_info.found & (1 << category)))
  		  break;
  	      }
! 	    else
  	      {
! 		if ((*(this->detector)) (&coding, &detect_info)
! 		    && highest
! 		    && (detect_info.found & (1 << category)))
  		  {
! 		    if (category == coding_category_utf_16_auto)
  		      {
! 			if (detect_info.found & CATEGORY_MASK_UTF_16_LE)
! 			  category = coding_category_utf_16_le;
! 			else
! 			  category = coding_category_utf_16_be;
  		      }
- 		    break;
  		  }
  	      }
! 	  }
  
        if (detect_info.rejected == CATEGORY_MASK_ANY)
  	{
--- 7125,7197 ----
        for (i = 0; src < src_end; i++, src++)
  	{
  	  c = *src;
! 	  if (c & 0x80)
  	    break;
+ 	  if (c < 0x20
+ 	      && (c == ISO_CODE_ESC || c == ISO_CODE_SI || c == ISO_CODE_SO)
+ 	      && inhibit_iso_escape_detection)
+ 	    {
+ 	      coding.head_ascii = src - coding.source;
+ 	      if (detect_coding_iso_2022 (&coding, &detect_info))
+ 		{
+ 		  /* We have scanned the whole data.  */
+ 		  if (! (detect_info.rejected & CATEGORY_MASK_ISO_7_ELSE))
+ 		    /* We didn't find an 8-bit code.  */
+ 		    src = src_end;
+ 		  break;
+ 		}
+ 	    }
  	}
        coding.head_ascii = src - coding.source;
  
!       if (src < src_end
! 	  || detect_info.found)
! 	{
! 	  if (src == src_end)
! 	    /* As all bytes are 7-bit, we can ignore non-ISO-2022 codings.  */
! 	    for (i = 0; i < coding_category_raw_text; i++)
  	      {
! 		category = coding_priorities[i];
! 		if (detect_info.found & (1 << category))
  		  break;
  	      }
! 	  else
! 	    for (i = 0; i < coding_category_raw_text; i++)
  	      {
! 		category = coding_priorities[i];
! 		this = coding_categories + category;
! 
! 		if (this->id < 0)
  		  {
! 		    /* No coding system of this category is defined.  */
! 		    detect_info.rejected |= (1 << category);
! 		  }
! 		else if (category >= coding_category_raw_text)
! 		  continue;
! 		else if (detect_info.checked & (1 << category))
! 		  {
! 		    if (highest
! 			&& (detect_info.found & (1 << category)))
! 		      break;
! 		  }
! 		else
! 		  {
! 		    if ((*(this->detector)) (&coding, &detect_info)
! 			&& highest
! 			&& (detect_info.found & (1 << category)))
  		      {
! 			if (category == coding_category_utf_16_auto)
! 			  {
! 			    if (detect_info.found & CATEGORY_MASK_UTF_16_LE)
! 			      category = coding_category_utf_16_le;
! 			    else
! 			      category = coding_category_utf_16_be;
! 			  }
! 			break;
  		      }
  		  }
  	      }
! 	}
  
        if (detect_info.rejected == CATEGORY_MASK_ANY)
  	{

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2004-09-12 23:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-08 17:54 Error building emacs-unicode-2 from CVS Jose E. Marchesi
2004-09-09  4:39 ` Janusz S. Bień
2004-09-09  8:25   ` Katsumi Yamaoka
2004-09-09 13:48     ` Jose E. Marchesi
2004-09-12 23:14 ` Kenichi Handa

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).