unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Björn Bidar" <bjorn.bidar@thaodan.de>
To: Konstantin Kharlamov <Hi-Angel@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: Adding git-commit highlight mode?
Date: Sun, 05 Jan 2025 02:42:47 +0200	[thread overview]
Message-ID: <16376.8434709468$1736037819@news.gmane.org> (raw)
In-Reply-To: <37733be4476e1c2b6e873c967c79cb0035959a9e.camel@yandex.ru> (Konstantin Kharlamov's message of "Thu, 02 Jan 2025 21:30:53 +0300")

Konstantin Kharlamov <Hi-Angel@yandex.ru> writes:

> Hi, just wanted to ask this before potentially taking on the initiative
> to only find the code will get rejected.
>
> I think a ballpark estimate of 90% of Git usage among CVSes in the
> modern world is fair to assume.
>
> But Emacs seems to be the only widely popular editor that still doesn't
> provide OOTB at least syntax highlight for git-commit format.

Does it do that if you use Emacs to commit? I.e. use VC?

> So, does
> anyone have opposition to adding a major mode that would be bound to
> filenames like `COMMIT_EDITMSG` and others, and would provide the
> aforementioned highlight?

The question is how would that benefit someone besides those that do
not VC nor Magit. The mechanism of calling git commit having Emacs
depends at least on with-editor which makes likely that the user would
use magit or maybe vc (IDK).

>
> P.S.: to answer potential question "why not magit" — first it's not
> OOTB experience. Second (but kinda related) it's a huge separate
> package which takes off some startup time (and as of writing the words
> commit highlight specifically doesn't work if you defer the load¹), but
> not everyone needs full git-interaction suite in Emacs. Magit is great,
> but I personally just grown over the years a bunch of zsh functions and
> aliases that automate my Git workflow as much as possible, so I don't
> think there's much to optimize still. I just want the highlight 😊 And
> I think, having it in Emacs would benefit the wider community too.

I might be that you load magit wrong since you seem to add :defer t to
your configuration but also very likely use other options such as :bind
which also enable deferred loading. That could mess up things.

> 1:
> https://emacs.stackexchange.com/questions/82842/deferring-magit-load-without-breaking-highlight-in-git-commit



  parent reply	other threads:[~2025-01-05  0:42 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-02 18:30 Adding git-commit highlight mode? Konstantin Kharlamov
2025-01-02 19:01 ` Eli Zaretskii
2025-01-02 19:07   ` Konstantin Kharlamov
2025-01-02 20:10     ` Stefan Kangas
2025-01-02 21:01       ` Eli Zaretskii
2025-01-02 21:38         ` Stefan Kangas
2025-01-03  5:26           ` Jim Porter
2025-01-02 21:40       ` Konstantin Kharlamov
2025-01-03  5:29         ` Jim Porter
2025-01-03 13:08       ` Jonas Bernoulli
2025-01-02 20:11     ` Eli Zaretskii
2025-01-02 21:19       ` Arsen Arsenović
2025-01-02 21:53         ` Stefan Kangas
2025-01-02 22:27           ` Arsen Arsenović
2025-01-03 21:02           ` Sean Whitton
2025-01-04  7:17             ` Eli Zaretskii
2025-01-04  9:52               ` Sean Whitton
2025-01-03  6:45         ` Eli Zaretskii
2025-01-02 19:17 ` Jim Porter
2025-01-02 19:19   ` Konstantin Kharlamov
2025-01-02 20:17   ` Eli Zaretskii
2025-01-03 21:14   ` Björn Bidar
2025-01-05 14:39     ` Philip Kaludercic
2025-01-05 22:48       ` Konstantin Kharlamov
     [not found]   ` <87r05jbnw2.fsf@>
2025-01-03 22:52     ` Konstantin Kharlamov
2025-01-04  1:22       ` Björn Bidar
     [not found]       ` <87v7uv9xub.fsf@>
2025-01-04  1:45         ` Konstantin Kharlamov
2025-01-05  0:46           ` Björn Bidar
     [not found]           ` <871pxiulxz.fsf@>
2025-01-05  3:55             ` Konstantin Kharlamov
2025-01-04 12:50         ` Jonas Bernoulli
2025-01-04 17:20           ` Jonas Bernoulli
2025-01-05  0:32           ` Björn Bidar
2025-01-05 18:47           ` Jim Porter
2025-01-05  0:42 ` Björn Bidar [this message]
     [not found] ` <875xmuum48.fsf@>
2025-01-05  3:49   ` Konstantin Kharlamov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='16376.8434709468$1736037819@news.gmane.org' \
    --to=bjorn.bidar@thaodan.de \
    --cc=Hi-Angel@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).