Re: [david.reitter@gmail.com: recentf: "Select coding system" on quit]

[David PONCE <david.ponce@wanadoo.fr>]

Hi,

> I think the attached patch will fix the problem.  Shall I
> install it?

Thanks for your patch. I tried it and when I compiled recentf.el
I got this message:

Compiling /home/ponce/installs/emacs/lisp/recentf.el...
File local-variables error: (error "Local variables list is not
properly terminated")
Wrote /home/ponce/installs/emacs/lisp/recentf.elc

This is because the ";;; Local Variables:\n" string confused
`hack-local-variables'!

Here is a new patch that fix that.

Sincerely,
David

Index: recentf.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/recentf.el,v
retrieving revision 1.35
diff -c -r1.35 recentf.el
*** recentf.el	23 Mar 2005 07:20:48 -0000	1.35
--- recentf.el	21 Apr 2005 15:10:52 -0000
***************
*** 1137,1142 ****
--- 1137,1148 ----
    ";;; Automatically generated by `recentf' on %s.\n"
    "Header to be written into the `recentf-save-file'.")
  
+ (defconst recentf-save-file-coding-system
+   (if (coding-system-p 'utf-8-emacs)
+       'utf-8-emacs
+     'emacs-mule)
+   "Coding system of the file `recentf-save-file'.")
+ 
  (defun recentf-save-list ()
    "Save the recent list.
  Write data into the file specified by `recentf-save-file'."
***************
*** 1144,1152 ****
--- 1150,1164 ----
    (condition-case error
        (with-temp-buffer
  	(erase-buffer)
+ 	(set-buffer-file-coding-system recentf-save-file-coding-system)
  	(insert (format recentf-save-file-header (current-time-string)))
  	(recentf-dump-variable 'recentf-list recentf-max-saved-items)
  	(recentf-dump-variable 'recentf-filter-changer-state)
+ 	(insert
+ 	 ;; Take care of not confusing `hack-local-variables'
+ 	 ";;; Local " "Variables:\n"
+ 	 (format ";;; coding: %s\n" recentf-save-file-coding-system)
+ 	 ";;; End:\n")
  	(write-file (expand-file-name recentf-save-file))
  	nil)
      (error