From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chetan Pandya Newsgroups: gmane.emacs.devel Subject: Re: size of emacs executable after unicode merge Date: Sat, 29 Nov 2008 20:50:02 -0800 (PST) Message-ID: <160961.44630.qm@web83203.mail.mud.yahoo.com> References: Reply-To: pandyacus@sbcglobal.net NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1228020626 28462 80.91.229.12 (30 Nov 2008 04:50:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Nov 2008 04:50:26 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 30 05:51:30 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L6eHJ-0000zM-Ia for ged-emacs-devel@m.gmane.org; Sun, 30 Nov 2008 05:51:29 +0100 Original-Received: from localhost ([127.0.0.1]:41509 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L6eG9-00023x-5i for ged-emacs-devel@m.gmane.org; Sat, 29 Nov 2008 23:50:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L6eG3-000230-Sa for emacs-devel@gnu.org; Sat, 29 Nov 2008 23:50:11 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L6eG1-00021x-LR for emacs-devel@gnu.org; Sat, 29 Nov 2008 23:50:10 -0500 Original-Received: from [199.232.76.173] (port=55404 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L6eG1-00021o-F7 for emacs-devel@gnu.org; Sat, 29 Nov 2008 23:50:09 -0500 Original-Received: from web83203.mail.mud.yahoo.com ([216.252.101.47]:32524) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1L6eG0-0003ks-V8 for emacs-devel@gnu.org; Sat, 29 Nov 2008 23:50:09 -0500 Original-Received: (qmail 46595 invoked by uid 60001); 30 Nov 2008 04:50:02 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=sbcglobal.net; h=X-YMail-OSG:Received:X-Mailer:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type:Message-ID; b=WgpsT6fsYwwfw+Qsz+yecnxDRmnhKNd/+JL/2Bg+qogM9YZJzq+FznRjqtpI6u1c4t+yRetLyEiKUgkOURe4jsT42c+rK0BCHLGQ56qmijkKp1K/W5frKEFqnb1p1RBJf9CaHUxtcaE+qM5iBRaZjwPPbijlzNsGY/PjsUYJIS8=; X-YMail-OSG: HNXDW70VM1l98jCJYu2QWyeOOSqiiKscwhifxhnroKJAK86ABf5HbL0pGDVeAf4YeAuMlGxK3BZyDyeoKQCGw7V.xfsFkXi2yV5M__8j8Xzu_DlxldIqOrKV3TaOiIdklz0JBgvAPbfug58ay8ZT1ApNi3L7OCCdZstGDp7D7NaY0sTQzuSvtRnf_X7A Original-Received: from [75.36.178.89] by web83203.mail.mud.yahoo.com via HTTP; Sat, 29 Nov 2008 20:50:02 PST X-Mailer: YahooMailWebService/0.7.218.2 In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: FreeBSD 6.x (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106331 Archived-At: While not directly on this, subject, looking at the isearch code, looks like there is some dead code. It would perhaps help to remove such code? Chetan Here is a diff with 22.3 isearch.el function isearch-other-meta-char: diff -u "c:/src/emacs-22.3/lisp/isearch.org.el" "c:/src/emacs-22.3/lisp/isearch.el" --- c:/src/emacs-22.3/lisp/isearch.org.el Tue Feb 05 10:49:45 2008 +++ c:/src/emacs-22.3/lisp/isearch.el Sun Nov 30 04:26:23 2008 @@ -1733,40 +1733,11 @@ (goto-char isearch-point))) (isearch-update)) (search-exit-option - (let (window) - (isearch-unread-key-sequence keylist) - (setq main-event (car unread-command-events)) - - ;; If we got a mouse click event, that event contains the - ;; window clicked on. maybe it was read with the buffer - ;; it was clicked on. If so, that buffer, not the current one, - ;; is in isearch mode. So end the search in that buffer. - - ;; ??? I have no idea what this if checks for, but it's - ;; obviously wrong for the case that a down-mouse event - ;; on another window invokes this function. The event - ;; will contain the window clicked on and that window's - ;; buffer is certainly not always in Isearch mode. - ;; - ;; Leave the code in, but check for current buffer not - ;; being in Isearch mode for now, until someone tells - ;; what it's really supposed to do. - ;; - ;; --gerd 2001-08-10. - - (if (and (not isearch-mode) - (listp main-event) - (setq window (posn-window (event-start main-event))) - (windowp window) - (or (> (minibuffer-depth) 0) - (not (window-minibuffer-p window)))) - (save-excursion - (set-buffer (window-buffer window)) - (isearch-done) - (isearch-clean-overlays)) - (isearch-done) - (isearch-clean-overlays) - (setq prefix-arg arg)))) + (isearch-unread-key-sequence keylist) + (setq main-event (car unread-command-events)) + (isearch-done) + (isearch-clean-overlays) + (setq prefix-arg arg)) (t;; otherwise nil (isearch-process-search-string key key))))) Diff finished. Sat Nov 29 20:34:35 2008