From: Paul Eggert <eggert@cs.ucla.edu>
To: Philipp Stephani <p.stephani2@gmail.com>, emacs-devel@gnu.org
Cc: Philipp Stephani <phst@google.com>, Alan Third <alan@idiocy.org>,
Anders Lindgren <andlind@gmail.com>
Subject: Re: [PATCH 01/13] Nextstep: Use instancetype explicit return type
Date: Sun, 21 May 2017 19:36:05 -0700 [thread overview]
Message-ID: <16003c01-1b84-677d-51c3-12646503cb59@cs.ucla.edu> (raw)
In-Reply-To: <20170520145841.94282-1-phst@google.com>
Oops, I spoke too quickly. This patch breaks the build on Ubuntu 16.04.2 LTS
x86-64, with the following being the first symptom:
In file included from nsterm.m:48:0:
nsterm.h: At top level:
nsterm.h:447:4: error: unknown type name ‘instancetype’
- (instancetype)menuDown: (id)sender;
^
Is that something you can fix? We need the Nextstep port to work with GNUstep as
well as with macOS.
Looking backward, I see that even before the recent patches the build was
already broken on Ubuntu 16.04.2 LTS, as follows:
nsfns.m: In function ‘Fns_set_mouse_absolute_pixel_position’:
nsfns.m:3101:3: error: unknown type name ‘CGPoint’
CGPoint mouse_pos = CGPointMake(mouse_x, mouse_y);
^
Still, we shouldn't make things worse. I'll CC: this to Alan Third and Anders
Lindgren to see whether they can advise.
next prev parent reply other threads:[~2017-05-22 2:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 14:58 [PATCH 01/13] Nextstep: Use instancetype explicit return type Philipp Stephani
2017-05-20 14:58 ` [PATCH 02/13] Declare Nextstep unexec functions in lisp.h Philipp Stephani
2017-05-20 14:58 ` [PATCH 03/13] Remove unused function print_regions Philipp Stephani
2017-05-20 14:58 ` [PATCH 04/13] Use NSCharacterCollection instead of CTCharacterCollection Philipp Stephani
2017-05-20 14:58 ` [PATCH 05/13] Make a function static that isn't used outside this file Philipp Stephani
2017-05-20 14:58 ` [PATCH 06/13] Remove calls to deprecated setUsesScreenFonts Philipp Stephani
2017-05-20 14:58 ` [PATCH 07/13] Remove trailing semicolons in method definitions Philipp Stephani
2017-05-20 14:58 ` [PATCH 08/13] Nextstep: remove some deprecated method calls Philipp Stephani
2017-05-20 14:58 ` [PATCH 09/13] Nextstep: Replace deprecated enumerators Philipp Stephani
2017-05-20 14:58 ` [PATCH 10/13] Remove unused automatic variables Philipp Stephani
2017-05-20 14:58 ` [PATCH 11/13] Clean up code around 'ns-list-services' Philipp Stephani
2017-05-20 14:58 ` [PATCH 12/13] Fix call of registerServicesMenuSendTypes Philipp Stephani
2017-05-20 14:58 ` [PATCH 13/13] Avoid uninitialized read Philipp Stephani
2017-05-21 15:30 ` John Wiegley
2017-05-20 20:23 ` [PATCH 01/13] Nextstep: Use instancetype explicit return type Paul Eggert
2017-05-20 22:45 ` mituharu
2017-05-21 20:00 ` Philipp Stephani
2017-05-22 2:36 ` Paul Eggert [this message]
2017-05-22 19:21 ` [PATCH] Fix GNUstep build Alan Third
2017-05-23 9:46 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16003c01-1b84-677d-51c3-12646503cb59@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=alan@idiocy.org \
--cc=andlind@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).