* Re: bug#16258: 24.3.50; [PATCH] eww: Add new function of region-search. [not found] ` <87r48z9ic3.fsf@building.gnus.org> @ 2014-11-10 21:41 ` Lars Magne Ingebrigtsen 2014-11-11 1:36 ` Stefan Monnier 0 siblings, 1 reply; 5+ messages in thread From: Lars Magne Ingebrigtsen @ 2014-11-10 21:41 UTC (permalink / raw) To: Kenjiro NAKAYAMA; +Cc: 16258, emacs-devel Lars Ingebrigtsen <larsi@gnus.org> writes: > Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> writes: > >>> I'm not sure that that's a useful eww mode >>> command, but it might be a useful global command... >> >> Then, how about delete the key map and include the eww-search-region? >> I want to know how much eww should provide its utilities like this function. > > Emacs is in a feature freeze, but I think it sounds like a very useful > thing to be able to just set a point and mark in any buffer, hit > `M-s M-s', and then be presented with the eww search results. Others > will have to comment on the keystroke, though. Does anybody have an opinion on this feature? I think it sounds useful, but I have no idea what global keystroke we would want to bind this to. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: bug#16258: 24.3.50; [PATCH] eww: Add new function of region-search. 2014-11-10 21:41 ` bug#16258: 24.3.50; [PATCH] eww: Add new function of region-search Lars Magne Ingebrigtsen @ 2014-11-11 1:36 ` Stefan Monnier 2014-11-11 2:42 ` Drew Adams 0 siblings, 1 reply; 5+ messages in thread From: Stefan Monnier @ 2014-11-11 1:36 UTC (permalink / raw) To: Lars Magne Ingebrigtsen; +Cc: 16258, Kenjiro NAKAYAMA, emacs-devel > Does anybody have an opinion on this feature? I think it sounds useful, > but I have no idea what global keystroke we would want to bind this to. We have the M-s prefix specifically for search-related commands, so there's a lot of key-binding room. Stefan ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: bug#16258: 24.3.50; [PATCH] eww: Add new function of region-search. 2014-11-11 1:36 ` Stefan Monnier @ 2014-11-11 2:42 ` Drew Adams 2014-11-15 20:10 ` Drew Adams 0 siblings, 1 reply; 5+ messages in thread From: Drew Adams @ 2014-11-11 2:42 UTC (permalink / raw) To: Stefan Monnier, Lars Magne Ingebrigtsen Cc: 16258, Kenjiro NAKAYAMA, emacs-devel > > Does anybody have an opinion on this feature? I think it sounds > > useful, > > but I have no idea what global keystroke we would want to bind > > this to. > > We have the M-s prefix specifically for search-related commands, so > there's a lot of key-binding room. I have no opinion on the feature. But it should not be named `*-region-search'. It does not search the region (IIUC). It searches for the selected text. ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: bug#16258: 24.3.50; [PATCH] eww: Add new function of region-search. 2014-11-11 2:42 ` Drew Adams @ 2014-11-15 20:10 ` Drew Adams 2014-11-15 20:11 ` Lars Magne Ingebrigtsen 0 siblings, 1 reply; 5+ messages in thread From: Drew Adams @ 2014-11-15 20:10 UTC (permalink / raw) To: Stefan Monnier, Lars Magne Ingebrigtsen Cc: 16258, Kenjiro NAKAYAMA, emacs-devel > it should not be named `*- region-search'. It does not > search the region (IIUC). It searches for the selected text. Again, please rename the command. The name is misleading. The command neither searches the region nor searches for the region (which would anyway be meaningless, from point). It searches a buffer (I assume) for the text in the region. People checking command names (via apropos commands or completion matching, for example) looking for commands that do something to the region can stumble on this. (And people looking for a command that searches for the selected text are unlikely to find it.) A guess is that this was named by someone for whom English is not the first language. "Search X" is not the same as "search for X". ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: bug#16258: 24.3.50; [PATCH] eww: Add new function of region-search. 2014-11-15 20:10 ` Drew Adams @ 2014-11-15 20:11 ` Lars Magne Ingebrigtsen 0 siblings, 0 replies; 5+ messages in thread From: Lars Magne Ingebrigtsen @ 2014-11-15 20:11 UTC (permalink / raw) To: Drew Adams; +Cc: 16258, Kenjiro NAKAYAMA, Stefan Monnier, emacs-devel Drew Adams <drew.adams@oracle.com> writes: >> it should not be named `*- region-search'. It does not >> search the region (IIUC). It searches for the selected text. > > Again, please rename the command. The name is misleading. It's not called that. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-15 20:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87zjnoxq5u.fsf@dhcp-193-97.nrt.redhat.com>
[not found] ` <87ha9viumj.fsf@building.gnus.org>
[not found] ` <8738lftbzk.fsf@dhcp-193-97.nrt.redhat.com>
[not found] ` <87r48z9ic3.fsf@building.gnus.org>
2014-11-10 21:41 ` bug#16258: 24.3.50; [PATCH] eww: Add new function of region-search Lars Magne Ingebrigtsen
2014-11-11 1:36 ` Stefan Monnier
2014-11-11 2:42 ` Drew Adams
2014-11-15 20:10 ` Drew Adams
2014-11-15 20:11 ` Lars Magne Ingebrigtsen
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).