proposed patch to expand-abbrev in abbrev.c

proposed patch to expand-abbrev in abbrev.c

[Karl Chen]

Hi Emacsers,

I think `expand-abbrev', should modify abbrevs-changed if it increments the
usage counter of an abbrev. Maybe a better solution would be to set it to
"'trivially" or use a secondary variable if this would be annoying to people
that don't have (setq save-abbrevs 'quietly). Otherwise, the usage count is
useless since often it doesn't get saved.

The following patch would just set it to true when an abbrev is expanded.

--- abbrev.c.~1.56.~    2002-08-20 00:46:31.000000000 -0700
+++ abbrev.c    2003-02-06 00:51:30.000000000 -0800
@@ -344,10 +344,16 @@
 
   /* Increment use count.  */
   if (INTEGERP (XSYMBOL (sym)->plist))
-    XSETINT (XSYMBOL (sym)->plist,
-            XINT (XSYMBOL (sym)->plist) + 1);
+    {
+      XSETINT (XSYMBOL (sym)->plist,
+               XINT (XSYMBOL (sym)->plist) + 1);
+      abbrevs_changed = 1;
+    }
   else if (INTEGERP (tem = Fget (sym, Qcount)))
-    Fput (sym, Qcount, make_number (XINT (tem) + 1));
+    {
+      Fput (sym, Qcount, make_number (XINT (tem) + 1));
+      abbrevs_changed = 1;
+    }
 
   /* If this abbrev has an expansion, delete the abbrev
      and insert the expansion.  */



-- 
Karl Chen / quarl@quarl.org

Re: proposed patch to expand-abbrev in abbrev.c

[Richard Stallman]

    I think `expand-abbrev', should modify abbrevs-changed if it increments the
    usage counter of an abbrev. Maybe a better solution would be to set it to
    "'trivially" or use a secondary variable if this would be annoying to people
    that don't have (setq save-abbrevs 'quietly).

I think that additional change is important--could you add that part?

Re: proposed patch to expand-abbrev in abbrev.c

[Karl Chen]

>>>>> "rms" == Richard Stallman <rms@gnu.org> writes:

    rms>     I think `expand-abbrev', should modify abbrevs-changed if it increments the
    rms>     usage counter of an abbrev. Maybe a better solution would be to set it to
    rms>     "'trivially" or use a secondary variable if this would be annoying to people
    rms>     that don't have (setq save-abbrevs 'quietly).

    rms> I think that additional change is important--could you add that part?

Which one?

-- 
Karl Chen / quarl@quarl.org

Re: proposed patch to expand-abbrev in abbrev.c

[Karl Chen]

My previous suggestion was that save-abbrevs's options not change, and
abbrevs-changed would be set to 'trivially if abbrevs had changed trivially
only (only the use count). this would require a lot of options for saving
abbrevs however. I think you mean to have save-abbrevs have an extra option
of 'trivially but this is ambiguous as to whether it's silent or not.

How about a new variable save-abbrevs-trivially which would affect the
behavior of updating the abbrevs-changed value. 



>>>>> "rms" == Richard Stallman <rms@gnu.org> writes:

    rms> I think `expand-abbrev', should modify abbrevs-changed if it increments the
    rms> usage counter of an abbrev. Maybe a better solution would be to set it to
    rms> "'trivially" or use a secondary variable if this would be annoying to people
    rms> that don't have (setq save-abbrevs 'quietly).


    rms> I think that additional change is important--could you add that part?

    rms>     Which one?

    rms> Using the value `trivally' for save-abbrevs to enable this.

-- 
Karl Chen / quarl@quarl.org

Re: proposed patch to expand-abbrev in abbrev.c

[Richard Stallman]

    My previous suggestion was that save-abbrevs's options not change, and
    abbrevs-changed would be set to 'trivially if abbrevs had changed trivially
    only (only the use count).

I did misunderstand that.

			       this would require a lot of options for saving
    abbrevs however. I think you mean to have save-abbrevs have an extra option
    of 'trivially but this is ambiguous as to whether it's silent or not.

Yes, that's what I meant and what I thought you meant too.  But both
ideas make sense together.  A value of `trivially' for
`abbrevs-changed' could be used to implement support for this value of
`save-abbrevs'.

By the way, please keep in mind for the doc strings that we do not
use the convention of writing a ' in front of a symbol name
in English text.  Our convention is to put `...' around it.