From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bill Wohler Newsgroups: gmane.emacs.devel Subject: Re: tool-bar-setup overwrites local tool-bar-map Date: Sun, 30 Apr 2006 23:16:04 -0700 Organization: Newt Software Message-ID: <15722.1146464164@olgas.newt.com> References: <31860.1145577819@olgas.newt.com> <423.1145580259@olgas.newt.com> <30570.1146421414@olgas.newt.com> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1146464191 13989 80.91.229.2 (1 May 2006 06:16:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 1 May 2006 06:16:31 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 01 08:16:28 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FaRhp-0003NI-P7 for ged-emacs-devel@m.gmane.org; Mon, 01 May 2006 08:16:26 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FaRhp-0003jy-5A for ged-emacs-devel@m.gmane.org; Mon, 01 May 2006 02:16:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FaRhb-0003jL-Kq for emacs-devel@gnu.org; Mon, 01 May 2006 02:16:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FaRha-0003j3-6Q for emacs-devel@gnu.org; Mon, 01 May 2006 02:16:11 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FaRha-0003j0-0v for emacs-devel@gnu.org; Mon, 01 May 2006 02:16:10 -0400 Original-Received: from [207.69.195.72] (helo=pop-sarus.atl.sa.earthlink.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FaRlJ-0004K8-0P; Mon, 01 May 2006 02:20:01 -0400 Original-Received: from h-64-105-34-169.snvacaid.dynamic.covad.net ([64.105.34.169] helo=olgas.newt.com) by pop-sarus.atl.sa.earthlink.net with esmtp (Exim 3.36 #10) id 1FaRhV-0001aq-00; Mon, 01 May 2006 02:16:05 -0400 Original-Received: by olgas.newt.com (Postfix, from userid 1000) id 5F87916FB7; Sun, 30 Apr 2006 23:16:04 -0700 (PDT) Original-Received: from olgas.newt.com (localhost [127.0.0.1]) by olgas.newt.com (Postfix) with ESMTP id 5BF6F16FB4; Sun, 30 Apr 2006 23:16:04 -0700 (PDT) Original-To: rms@gnu.org In-reply-to: Comments: In-reply-to Richard Stallman message dated "Mon, 01 May 2006 00:19:56 -0400." X-Mailer: MH-E 7.95; nmh 1.1; GNU Emacs 22.0.50 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png Mail-Followup-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53714 Archived-At: Richard Stallman wrote: > If one runs tool-bar-mode first, and then MH-E, one sees the one pair of > Preferences/Help buttons (the ones defined by MH-E). If vice-versa, one > sees *two* pairs of Preferences/Help buttons (the ones defined by MH-E > plus the ones defined by tool-bar). > > Now I understand the point of your patch. > But it seems to me that ALL the standard tool-bar items > ought to be added to the standard tool-bar map. > Not just Help and Preferences. > > Ah, now I see. All the rest are added using > tool-bar-add-item-from-menu, which uses (default-value 'tool-bar-map). > > So I believe your patch is correct. But I think this is cleaner. > Does it work? I agree. Your patch is cleaner and is closer to the documented usage. And it works (for me). I'd be happy if you checked it in. Thanks. -- Bill Wohler http://www.newt.com/wohler/ GnuPG ID:610BD9AD Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian! If you're passed on the right, you're in the wrong lane.