unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Benedikt Tissot <benedikt.tissot@googlemail.com>
To: emacs-devel@gnu.org
Subject: shell-command-to-string uses local shell for remote
Date: Sun, 31 Mar 2019 21:28:10 +0200	[thread overview]
Message-ID: <1554060490.28676.0@googlemail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

Hello dear emacs maintainers,

If the local used shell does not exist on the remote the 
shell-command-to-string function from simple.el does not work as 
expected. The reason for this is that the variable shell-file-name is 
wrong and therefore one only gets a string saying that the shell does 
not exist.
Changing the function to
(defun shell-command-to-string (command)
  "Execute shell command COMMAND and return its output as a string."
  (with-output-to-string
    (with-current-buffer
      standard-output
      (let ((shell-file-name
             (with-temp-buffer
               (apply #'process-file "printenv" nil t nil '("SHELL"))
               (string-trim-right (buffer-string)))))
        (process-file shell-file-name nil t nil shell-command-switch 
command)))))
does work for remotes that do not have the local shell, too.
I hope this is the right place for this and additionally wanted to 
thank you for maintaining emacs.

Best regards,
Benedikt Tissot


[-- Attachment #2: Type: text/html, Size: 1419 bytes --]

             reply	other threads:[~2019-03-31 19:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-31 19:28 Benedikt Tissot [this message]
2019-04-01  6:36 ` shell-command-to-string uses local shell for remote Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1554060490.28676.0@googlemail.com \
    --to=benedikt.tissot@googlemail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).