From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line Date: Tue, 19 Mar 2019 02:13:20 +0300 Message-ID: <1552950800.23527.0@yandex.ru> References: <20190316015314.2335-1-Hi-Angel@yandex.ru> <20190316015314.2335-2-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="71966"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 19 00:13:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h61S0-000IWY-2G for ged-emacs-devel@m.gmane.org; Tue, 19 Mar 2019 00:13:48 +0100 Original-Received: from localhost ([127.0.0.1]:48788 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h61Ry-0004VR-VU for ged-emacs-devel@m.gmane.org; Mon, 18 Mar 2019 19:13:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h61Rs-0004VM-JC for emacs-devel@gnu.org; Mon, 18 Mar 2019 19:13:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h61Rq-0008FT-CG for emacs-devel@gnu.org; Mon, 18 Mar 2019 19:13:40 -0400 Original-Received: from forward105p.mail.yandex.net ([2a02:6b8:0:1472:2741:0:8b7:108]:60249) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h61Re-0007tK-RF; Mon, 18 Mar 2019 19:13:35 -0400 Original-Received: from mxback19g.mail.yandex.net (mxback19g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:319]) by forward105p.mail.yandex.net (Yandex) with ESMTP id 908FD4D402AF; Tue, 19 Mar 2019 02:13:22 +0300 (MSK) Original-Received: from smtp1p.mail.yandex.net (smtp1p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:6]) by mxback19g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id dWl6Aqn1Zq-DM6Ciaga; Tue, 19 Mar 2019 02:13:22 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1552950802; bh=w67iUXL0G1Z4mksgU3ZKrXnT3jeGs4YlgqmONcs/IXo=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=G9lwlGwmAW5wUsQo44e6y1f/v8e+25+NneflUic09mJWNNSHhiPtgUbkcppdOjVgG /M/7qcOzfOFlAs8PmIPq9FVcOmuB/JkJ4Gvs6abxV9gYEGWc32YX/Ng4wGwIuuWw1f Ez/opw5KiYWoueCUzhVl4zEE6zPEtibBPE+l33EU= Authentication-Results: mxback19g.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id KIhYPo2eDl-DLvSUTi0; Tue, 19 Mar 2019 02:13:21 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) In-Reply-To: <1552945510.7027.2@yandex.ru> X-Mailer: geary/master~g91967edc X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a02:6b8:0:1472:2741:0:8b7:108 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234344 Archived-At: =F7 =F7=D4, =CD=C1=D2 19, 2019 at 12:45 =E4=F0 (AM), Konstantin Kharlamov=20 =CE=C1=D0=C9=D3=C1=CC: >=20 >=20 > =F7 =F0=CE, =CD=C1=D2 18, 2019 at 11:16 =F0=F0 (PM), Eli Zaretskii=20 > =CE=C1=D0=C9=D3=C1=CC: >>> Date: Mon, 18 Mar 2019 22:15:27 +0300 >>> From: Konstantin Kharlamov >>> Cc: emacs-devel@gnu.org >>>=20 >>> > Can you provide those additional details? >>>=20 >>> I'm not sure what additional details you want. >>=20 >> OK, let me ask more specific questions: >>=20 >> 1. Why was the amount of whitespace in the tags table different=20 >> from >> that in the source file? >=20 > It's a bug in anjuta-tags >=20 >> 2. What command(s) was/were used to produce the tags table? >=20 > anjuta-tags -e file.vala >=20 >> 3. Why are the issue and you talking about "trailing whitespace", >> while the difference between Expected and Actual in the issue is >> in leading whitespace, not trailing whitespace? >=20 > Sorry for confusion here, I was imagining: given a string, whitespace=20 > may "trail" on both sides of it. But I'm not a native speaker. >=20 >>> Let's make it the other way around: please, provide any language >>> example, where having the trailing space may be significant for >>> unambigiously determining the tag. >>=20 >> etags.el doesn't understand any languages, that is the job of the >> program that produces the tags table. etags.el just follows the=20 >> rules >> for the format of tags in the tags table. I don't know about=20 >> trailing >> whitespace, but tags for HTML files surely include embedded >> whitespace, for example. >>=20 >> So once again, I suggest to focus on the particular problem you had, >> because I'd like to find a solution for that without making >> backward-incompatible changes in behavior of etags.el. >=20 > Okay, whatever. I get your position. Though I disagree, but we=20 > clearly have different priorities here: while I'm focusing on a Emacs=20 > user, you're focusing on technical correctness. I doubt this=20 > discussion can move anywhere further, let's leave it at it. >=20 > Can my 1-st patch from the series be merged though? Oh, wait, I noticed despite going to a tag I'm getting "Rerun etags"=20 message. Something is wrong, let me investigate. =