From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line Date: Sun, 17 Mar 2019 22:29:55 +0300 Message-ID: <1552850995.16839.1@yandex.ru> References: <20190316015314.2335-1-Hi-Angel@yandex.ru> <20190316015314.2335-2-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="180468"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 17 20:30:12 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5bU4-000krl-EB for ged-emacs-devel@m.gmane.org; Sun, 17 Mar 2019 20:30:12 +0100 Original-Received: from localhost ([127.0.0.1]:59376 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5bU3-0004fO-GD for ged-emacs-devel@m.gmane.org; Sun, 17 Mar 2019 15:30:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5bTx-0004eM-KO for emacs-devel@gnu.org; Sun, 17 Mar 2019 15:30:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5bTw-00037P-QY for emacs-devel@gnu.org; Sun, 17 Mar 2019 15:30:05 -0400 Original-Received: from forward104o.mail.yandex.net ([37.140.190.179]:51221) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5bTr-00035N-0B; Sun, 17 Mar 2019 15:30:00 -0400 Original-Received: from mxback19j.mail.yandex.net (mxback19j.mail.yandex.net [IPv6:2a02:6b8:0:1619::95]) by forward104o.mail.yandex.net (Yandex) with ESMTP id EAFB6940E20; Sun, 17 Mar 2019 22:29:56 +0300 (MSK) Original-Received: from smtp1p.mail.yandex.net (smtp1p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:6]) by mxback19j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id aKig8ZI8cS-Tuae7vPY; Sun, 17 Mar 2019 22:29:56 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1552850996; bh=rktV1s5/HDcLCw6LsRXLj7ZEMmGw3sChJoufqNBBVpM=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=TJzNY3RK7N48pF3qnMzmIKHIapPmqeLzKYLHo/uqSxLnDAOMrIZATxLx1VpOEdWhd Hj1laYJh4EyILSb9fH6sTozwRT1h9dRZk5hNkCWzxsK9KOhk9SXKm7EiA/H4TAqgsh NjjMVf4zrDFo/bBdQdpNfgUNrmgPIQuV3BFDR/4c= Authentication-Results: mxback19j.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 7ygYDIhEu5-TtVKmRYt; Sun, 17 Mar 2019 22:29:56 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) In-Reply-To: <83d0mpwbkc.fsf@gnu.org> X-Mailer: geary/master~g91967edc X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 37.140.190.179 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234295 Archived-At: =F7 =F7=D3, =CD=C1=D2 17, 2019 at 10:22 =F0=F0 (PM), Eli Zaretskii=20 =CE=C1=D0=C9=D3=C1=CC: >> Date: Sun, 17 Mar 2019 22:06:26 +0300 >> From: Konstantin Kharlamov >> Cc: emacs-devel@gnu.org >>=20 >> Are patches 1 and 3 okay? >=20 > Part 3 has the same problem as part 2, and I think I already responded > to it. Ah, sorry, I thought that was a general comment, i.e. a reply to my=20 mail but not specific to the patch. Okay, so: ^M appears in selective-display-mode only in the end of a=20 line. So, matching the ^M have been relevant before the patch: we=20 wanted to match beginning of the line, which is defined by ^M character. But after my patch applied we do not match beginning of the line=20 anymore, at all, not in any mode. We only match the exact tag, with=20 trimmed space. I.e. matching for ^ in usual mode and for ^M in=20 selective-display-mode is no longer needed. =