From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line Date: Sun, 17 Mar 2019 22:06:26 +0300 Message-ID: <1552849586.16839.0@yandex.ru> References: <20190316015314.2335-1-Hi-Angel@yandex.ru> <20190316015314.2335-2-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="88083"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 17 20:06:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5b7S-000MlN-F8 for ged-emacs-devel@m.gmane.org; Sun, 17 Mar 2019 20:06:50 +0100 Original-Received: from localhost ([127.0.0.1]:59109 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5b7R-0006Cu-EN for ged-emacs-devel@m.gmane.org; Sun, 17 Mar 2019 15:06:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5b7D-0006Bv-9A for emacs-devel@gnu.org; Sun, 17 Mar 2019 15:06:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5b7C-0000DA-HI for emacs-devel@gnu.org; Sun, 17 Mar 2019 15:06:35 -0400 Original-Received: from forward103j.mail.yandex.net ([5.45.198.246]:37439) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5b79-0000Am-F1; Sun, 17 Mar 2019 15:06:32 -0400 Original-Received: from mxback10o.mail.yandex.net (mxback10o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::24]) by forward103j.mail.yandex.net (Yandex) with ESMTP id 519C56740631; Sun, 17 Mar 2019 22:06:28 +0300 (MSK) Original-Received: from smtp4o.mail.yandex.net (smtp4o.mail.yandex.net [2a02:6b8:0:1a2d::28]) by mxback10o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id UFyeW5NpLA-6SFW8NFT; Sun, 17 Mar 2019 22:06:28 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1552849588; bh=iZyXrjyYwxQHqTUoGh/4aRJclaEzn1efnniD9oNYJtM=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=LHhwccnefm8Gp/rxhwBGGc4etkodQpAEzQYKpTf658igdzYu38ahl6mYT+6hIQ+bq ZvelULvrderD8Sl0nraDrR8QGum5HbskcOh+dPsb+O8AUADaM15m1oTGOwwhqFZINC Cb4Yyg0EiJzXnMCqsIJMLvFiihaHiKQyfqo3vDuY= Authentication-Results: mxback10o.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp4o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id gDL4oOXwAm-6RjutKiu; Sun, 17 Mar 2019 22:06:27 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) In-Reply-To: <834l81y1hd.fsf@gnu.org> X-Mailer: geary/master~g91967edc X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.45.198.246 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234291 Archived-At: =F7 =F7=D3, =CD=C1=D2 17, 2019 at 6:17 =F0=F0 (PM), Eli Zaretskii=20 =CE=C1=D0=C9=D3=C1=CC: >> Date: Sun, 17 Mar 2019 06:41:41 +0300 >> From: Konstantin Kharlamov >> Cc: emacs-devel@gnu.org >>=20 >> > The ^M character is what causes that "..." ellipsis. You cannot >> > search for it interactively because Emacs prevents that, but the >> > character is there in the buffer text. >>=20 >> Okay, well, I couldn't find it by evaluating (re-search-forward=20 >> "^M") >> either. >>=20 >> So, given the character can't be inspected, the old code couldn't=20 >> even >> do anything :) >=20 > I suggest to read the node "Selective Display" in the ELisp manual > about this feature, and how the ^M characters come into play. Ok, the docs say that every newline in "invisible part" is replaced=20 with ^M. But this doesn't change the fact this ^M can't be inspected, in=20 particular by (looking-at "\^m") that the 2-nd patch removes. I just=20 tested that. Oh well, whatever, I'm not really motivated to discuss that, let's just=20 drop 2-nd patch. Are patches 1 and 3 okay? =