From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line Date: Sun, 17 Mar 2019 00:47:51 +0300 Message-ID: <1552772871.23693.0@yandex.ru> References: <20190316015314.2335-1-Hi-Angel@yandex.ru> <20190316015314.2335-2-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="198217"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 16 22:48:40 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5HAV-000pSv-Nt for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 22:48:39 +0100 Original-Received: from localhost ([127.0.0.1]:46770 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5HAU-0003EB-Ph for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 17:48:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5H9u-0003E6-Tt for emacs-devel@gnu.org; Sat, 16 Mar 2019 17:48:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5H9t-0004cs-NY for emacs-devel@gnu.org; Sat, 16 Mar 2019 17:48:02 -0400 Original-Received: from forward101p.mail.yandex.net ([2a02:6b8:0:1472:2741:0:8b7:101]:57516) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5H9o-0004ZH-VV; Sat, 16 Mar 2019 17:47:58 -0400 Original-Received: from mxback9j.mail.yandex.net (mxback9j.mail.yandex.net [IPv6:2a02:6b8:0:1619::112]) by forward101p.mail.yandex.net (Yandex) with ESMTP id 145393280279; Sun, 17 Mar 2019 00:47:53 +0300 (MSK) Original-Received: from smtp1p.mail.yandex.net (smtp1p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:6]) by mxback9j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id XAWoF6ytln-lqi8ql5P; Sun, 17 Mar 2019 00:47:53 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1552772873; bh=DndI5slttjXQargaFa02ia4r75AYh6miE1lALBRvWMQ=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=vVhhiPlSpD5e/5yuKzkfGyWkNipaNUgDaEXmWV5boxJz4eQ9ctE21MkdTh7IAIQe1 itemrqaOB7jTUyQ49AGGpOY0Y3TGs10L1UN66FUzazw8YWPmhpL8Zn2S+khabcACIQ 8buqf+OcmjCh/6Cis3WkJfofbXMYKswsDFqjIsfw= Authentication-Results: mxback9j.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id xxlcgExu68-lpRufQrp; Sun, 17 Mar 2019 00:47:52 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) In-Reply-To: <1552770756.27232.0@yandex.ru> X-Mailer: geary/master~g91967edc X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a02:6b8:0:1472:2741:0:8b7:101 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234244 Archived-At: =D0=92 =D0=92=D1=81, =D0=BC=D0=B0=D1=80 17, 2019 at 12:12 =D0=94=D0=9F (AM)= , Konstantin Kharlamov=20 =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB: >=20 >=20 > =D0=92 =D0=A1=D0=B1, =D0=BC=D0=B0=D1=80 16, 2019 at 7:26 =D0=9F=D0=9F (PM= ), Eli Zaretskii=20 > =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB: >>> Date: Sat, 16 Mar 2019 18:42:44 +0300 >>> From: Konstantin Kharlamov >>> Cc: emacs-devel@gnu.org >>>=20 >>> >> - (and (eq selective-display t) >>> >> - (looking-at "\^m") >>> >> - (forward-char 1)) >>> >> (beginning-of-line))) >>> > >>> > Did you actually try this change with selective-display in=20 >>> effect? >>> > Because I'm not sure it is correct in that case. >>> > >>> > Thanks. >>>=20 >>> Hmm=E2=80=A6 I will try a bit later, but the code seems really >>> straightforward: >>> 1. if current character is ^M, then step forward >>> 2. step to the beginnig of the line >>>=20 >>> The 2 undoes 1. >>=20 >> ^M has special meaning in selective-display mode. >=20 > Thanks, so, I just tried playing with the mode, and I haven't even=20 > found ^M anywhere. I wonder if the ^M being added by the mode is in=20 > the past, that just no longer happening. >=20 > Specifically, I did: >=20 > 1. wrote in scratch buffer > test > test > test > 2. evaluated (set-selective-display 1) which transformed the look of=20 > the text to > test... > 3.=CE=B1 Tried searching for ^M by pressing C-s C-q C-m. It's failing to=20 > find anything. > 3.=CE=B2 Put the caret before the triple dot, as in "test|...", and=20 > evaluated (char-after (point)) and (char-after (+ 1 (point))). The=20 > first returns "C-j" character, i.e. a newline; the second returns=20 > "space character". They're both the exact characters that actually=20 > are in text, as if I didn't enable selective-display. >=20 > So, even disregarding my patches (because I haven't managed to test=20 > this possible corner-case), the need for ^M workarounds is just no=20 > longer needed. That said, would be nice if somebody could confirm my findings, because=20 I can not find whether my current Emacs built from vanilla branch or=20 the harf-buzz one; and I'm a bit worrying that this could've been=20 change specific to harf-buzz branch. =