From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line Date: Sat, 16 Mar 2019 18:42:44 +0300 Message-ID: <1552750964.20097.0@yandex.ru> References: <20190316015314.2335-1-Hi-Angel@yandex.ru> <20190316015314.2335-2-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="86808"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 16 16:44:12 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5BTn-000MR2-Ii for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 16:44:11 +0100 Original-Received: from localhost ([127.0.0.1]:43183 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5BTm-0007T5-Fk for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 11:44:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5BSZ-0007Sj-1Y for emacs-devel@gnu.org; Sat, 16 Mar 2019 11:42:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5BSY-0005oa-8h for emacs-devel@gnu.org; Sat, 16 Mar 2019 11:42:55 -0400 Original-Received: from forward103o.mail.yandex.net ([2a02:6b8:0:1a2d::606]:34384) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5BSW-0005n6-QR; Sat, 16 Mar 2019 11:42:53 -0400 Original-Received: from mxback9o.mail.yandex.net (mxback9o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::23]) by forward103o.mail.yandex.net (Yandex) with ESMTP id 8B0655F80B44; Sat, 16 Mar 2019 18:42:50 +0300 (MSK) Original-Received: from smtp3o.mail.yandex.net (smtp3o.mail.yandex.net [2a02:6b8:0:1a2d::27]) by mxback9o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 1wMIhgvXzL-go3Gv8jA; Sat, 16 Mar 2019 18:42:50 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1552750970; bh=aZAr28f5hL1OXq3kz1xXRbdq5VZ5hXWR1MliwMwUWGw=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=jsBQHDVuRtj9ju3FSQgZXRiSjMr5i+QehTmjQtNZm8rFPGIQ/pnKzII0837+DZhBP +GRu+CGbEeGGyD1Hg0c36r7CGj1oWqXjYV6tk9yfDb9pYC5x9aFLHgj0d5tp9tvcCX Mspo5/yqa6RU9eqdC6qud39B1ndJNr5mziupdH3g= Authentication-Results: mxback9o.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp3o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id NxKOLzgaU5-gnAiPS9D; Sat, 16 Mar 2019 18:42:49 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) In-Reply-To: <83va0jxa48.fsf@gnu.org> X-Mailer: geary/master~g91967edc X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a02:6b8:0:1a2d::606 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234221 Archived-At: =C2 =D1=E1, =EC=E0=F0 16, 2019 at 3:43 =CF=CF (PM), Eli Zaretskii=20 =ED=E0=EF=E8=F1=E0=EB: >> From: Konstantin Kharlamov >> Date: Sat, 16 Mar 2019 04:53:13 +0300 >>=20 >> diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el >> index 05dc7aa1baf..62637414ef8 100644 >> --- a/lisp/progmodes/etags.el >> +++ b/lisp/progmodes/etags.el >> @@ -1395,11 +1395,6 @@ etags-goto-tag-location >> (re-search-forward pat nil t) >> (user-error "Rerun etags: `%s' not found in %s" >> pat buffer-file-name))) >> - ;; Position point at the right place >> - ;; if the search string matched an extra Ctrl-m at the=20 >> beginning. >> - (and (eq selective-display t) >> - (looking-at "\^m") >> - (forward-char 1)) >> (beginning-of-line))) >=20 > Did you actually try this change with selective-display in effect? > Because I'm not sure it is correct in that case. >=20 > Thanks. Hmm=85 I will try a bit later, but the code seems really=20 straightforward: 1. if current character is ^M, then step forward 2. step to the beginnig of the line The 2 undoes 1. =