From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: David PONCE Newsgroups: gmane.emacs.devel Subject: Re: The display margin Date: Fri, 28 Nov 2003 13:47:24 +0100 (CET) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <15434658.1070023644521.JavaMail.www@wwinf0402> Reply-To: david.ponce@wanadoo.fr NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1070023689 3801 80.91.224.253 (28 Nov 2003 12:48:09 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 28 Nov 2003 12:48:09 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Nov 28 13:48:06 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1APi2Y-0001nu-00 for ; Fri, 28 Nov 2003 13:48:06 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1APi2Y-0005O2-00 for ; Fri, 28 Nov 2003 13:48:06 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1APizy-0004yW-0Z for emacs-devel@quimby.gnus.org; Fri, 28 Nov 2003 08:49:30 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1APizt-0004yQ-4A for emacs-devel@gnu.org; Fri, 28 Nov 2003 08:49:25 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1APizL-0004qT-A4 for emacs-devel@gnu.org; Fri, 28 Nov 2003 08:49:24 -0500 Original-Received: from [193.252.22.27] (helo=mwinf0402.wanadoo.fr) by monty-python.gnu.org with esmtp (Exim 4.24) id 1APizK-0004qN-T8 for emacs-devel@gnu.org; Fri, 28 Nov 2003 08:48:51 -0500 Original-Received: from wwinf0402 (wwinf0402 [172.22.135.29]) by mwinf0402.wanadoo.fr (SMTP Server) with ESMTP id 82B38800085; Fri, 28 Nov 2003 13:47:24 +0100 (CET) Original-To: storm@cua.dk X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:18190 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:18190 Hi Kim, > Finally, when you use a block cursor, images are no longer shown in > "negative" when your window cursor is a filled block cursor (only > the border of the image is highlighted now). So clicking on an > image no longer makes it "unreadable"... That's very nice! However when using a bar cursor the image is still shown in "negative". Perhaps it would make sense to use an hollow cursor in that case too. Another possibility could be to just draw the bar in that case (a la "Open Office"). To do the latter I applied the following patch to xterm.c: Index: src/xterm.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/xterm.c,v retrieving revision 1.822 diff -c -r1.822 xterm.c *** src/xterm.c 17 Nov 2003 06:06:24 -0000 1.822 --- src/xterm.c 28 Nov 2003 12:43:35 -0000 *************** *** 7335,7340 **** --- 7335,7341 ---- if (cursor_glyph == NULL) return; + #if 0 /* If on an image, draw like a normal cursor. That's usually better visible than drawing a bar, esp. if the image is large so that the bar might not be in the window. */ *************** *** 7345,7350 **** --- 7346,7352 ---- draw_phys_cursor_glyph (w, row, DRAW_CURSOR); } else + #endif { Display *dpy = FRAME_X_DISPLAY (f); Window window = FRAME_X_WINDOW (f); I am not sure what solution is the best. David