From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?utf-8?Q?Jostein=20Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.devel Subject: Re: Regarding adding additional default font-lock faces Date: Thu, 09 Aug 2018 13:04:23 +0200 Message-ID: <1533812663.2257232.1468575768.4605098F@webmail.messagingengine.com> References: <1533151464.4048871.1460317672.1FF86CD1@webmail.messagingengine.com> <1533193402.1422491.1460826912.040BAF55@webmail.messagingengine.com> Reply-To: jostein@kjonigsen.net NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="_----------=_153381266322572320" Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1533812664 14722 195.159.176.226 (9 Aug 2018 11:04:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 9 Aug 2018 11:04:24 +0000 (UTC) Cc: jostein@kjonigsen.net, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 09 13:04:20 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnijq-0003i7-Qo for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2018 13:04:19 +0200 Original-Received: from localhost ([::1]:49800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnilx-0002pm-H2 for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2018 07:06:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnik7-0001U3-3u for emacs-devel@gnu.org; Thu, 09 Aug 2018 07:04:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnik1-0003UN-4o for emacs-devel@gnu.org; Thu, 09 Aug 2018 07:04:35 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39039) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fnik0-0003H6-SD for emacs-devel@gnu.org; Thu, 09 Aug 2018 07:04:29 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9F65C21BBE; Thu, 9 Aug 2018 07:04:24 -0400 (EDT) Original-Received: from web5 ([10.202.2.215]) by compute6.internal (MEProxy); Thu, 09 Aug 2018 07:04:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-transfer-encoding :content-type:date:from:in-reply-to:message-id:mime-version :references:reply-to:subject:to:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Xs2Kq2RT5y+siVv8ynnwhjI5jXm2WXxx8YroZTrQJ PI=; b=tUjZYVAOgrThRt011LH11Xr1bFXE9pyzQoNq2C8FzPehRLtDu16vmR+lz dWwg3oM9KQVQrutHDTYT6vdVwBRcU5tml0YVWQtnGdgo2VNqSUtuSuRo01GYIf9P v9rJEQdFlc4tIUjSM7KQpqEhV6UKaS75nAWXdIIHfSY9dMPHVbb/yWJzySQR8dHp avS9q/JEaa/S1KXJbKsQQ17hUYly+NDhLPPqdrrcQpf+h3/XnYaA24U+5ShDZ2Y2 pboPKu/mzz/ZrpCmXt3nHEOM2cis8mHk9IscOw+GRnFa51C94uhBFF3uR9IUSxWw oXWTkeLWuDfYtT1oMCuClEDatwv0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :reply-to:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Xs2Kq2RT5y+siVv8ynnwhjI5jXm2WXxx8YroZTrQJPI=; b=kN0fQTY1d4GI R+HiCKBPapvnwlD/8sihyIQ02rugctJocmd8ExVZwWHpQKcdVUzrihefgTgrf03/ DoAISHoIN7DqF62YDWHyUmW2ZxpAZJ+RgQrkoSXxYpUUZDJegDZ3S3orWRzgBvKy t+HA1XxrHczQnW4Y7Y8fWqtSdsGmOTigMBUA7r+HleG6E17JAx1drmYOCol5KfrO KLrhv0DBXR14dTmB4hxY+Xdp4IPxBeNnYZmfini5HwCcTVsIRYdkd5Msi4HYBb/5 3gPTIJXmuYvaJiaJLeMuxWrv5PiMDWxNXpYjbd4Ks1i/jIE6XVwbgRz83klftjK1 K9IGBhRkGA== X-ME-Proxy: X-ME-Sender: Original-Received: by mailuser.nyi.internal (Postfix, from userid 99) id 8642E9E10A; Thu, 9 Aug 2018 07:04:23 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface - ajax-9a5384d7 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228327 Archived-At: This is a multi-part message in MIME format. --_----------=_153381266322572320 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Thu, Aug 2, 2018, at 1:53 PM, Stefan Monnier wrote: >> Which is fine. But can't we have a defface for this whose default >> value is nil? > Of course. OK. Sounds good. In which case... Where do I start?=20 Do I just start hacking at lisp/font-lock.el and send in patches, or should we discuss which faces would be useful to add first? Personally I see at least a need for: * font-lock-function-call-face * font-lock-decorator-face ("decorator" is another commonly used for the "attribute" concept and less likely to be confused with for instance HTML/XML attributes) Are there any other nice-to-have default faces anyone can think of? Besides the actual LISP-code itself... What's the process for documenting such changes? What other "house-keeping" needs to go with such a code-change? Let me know, and I'll try to get it done. -- Regards Jostein Kj=C3=B8nigsen jostein@kjonigsen.net =F0=9F=8D=B5 jostein@gmail.com https://jostein.kjonigsen.net --_----------=_153381266322572320 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="utf-8"
On Thu, Aug 2, 2018, at 1:53 PM, Stefan Monnier wrote:
Which is fine. But can't we have= a defface for this whose default
value is nil?
Of course.

OK. Sounds good.

In which case... Where do I start?

Do I just start hacking at lisp/font-lock.el and send in patches, or s= hould we discuss which faces would be useful to add first?

Personally I see at least a need for:

  • font-lock-function-call-face
  • font-lock-decorator-face (= "decorator" is another commonly used for the "attribute" concept and less l= ikely to be confused with for instance HTML/XML attributes)

Are there any other nice-to-have default faces anyone can think of?

Besides the actual LISP-code itself... What's the process for document= ing such changes? What other "house-keeping" needs to go with such a code-c= hange?

Let me know, and I'll try to get it done.

--
Regard= s
Jostein Kj=C3=B8nigsen

jostein@k= jonigsen.net =F0=9F=8D=B5 jostein@= gmail.com
https://= jostein.kjonigsen.net



--_----------=_153381266322572320--