unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: jostein@kjonigsen.net, emacs-devel@gnu.org
Subject: Re: Regarding adding additional default font-lock faces
Date: Thu, 09 Aug 2018 13:04:23 +0200	[thread overview]
Message-ID: <1533812663.2257232.1468575768.4605098F@webmail.messagingengine.com> (raw)
In-Reply-To: <jwvy3dphtvg.fsf-monnier+Inbox@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

On Thu, Aug 2, 2018, at 1:53 PM, Stefan Monnier wrote:
>> Which is fine. But can't we have a defface for this whose default
>> value is nil?
> Of course.

OK. Sounds good.

In which case... Where do I start? 

Do I just start hacking at lisp/font-lock.el and send in patches, or
should we discuss which faces would be useful to add first?
Personally I see at least a need for:

 * font-lock-function-call-face
 * font-lock-decorator-face ("decorator" is another commonly used for
   the "attribute" concept and less likely to be confused with for
   instance HTML/XML attributes)
Are there any other nice-to-have default faces anyone can think of?

Besides the actual LISP-code itself... What's the process for
documenting such changes? What other "house-keeping" needs to go with
such a code-change?
Let me know, and I'll try to get it done.

--
Regards
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjonigsen.net




[-- Attachment #2: Type: text/html, Size: 2024 bytes --]

  parent reply	other threads:[~2018-08-09 11:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 19:24 Regarding adding additional default font-lock faces Jostein Kjønigsen
2018-08-01 21:53 ` Stefan Monnier
2018-08-02  7:03   ` Jostein Kjønigsen
2018-08-02 11:53     ` Stefan Monnier
2018-08-03  7:46       ` Nathan Moreau
2018-08-09 11:04       ` Jostein Kjønigsen [this message]
2018-08-09 13:57         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533812663.2257232.1468575768.4605098F@webmail.messagingengine.com \
    --to=jostein@secure.kjonigsen.net \
    --cc=emacs-devel@gnu.org \
    --cc=jostein@kjonigsen.net \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).