From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?iso-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: About the :distant-foreground face attribute Date: Sun, 12 Jan 2014 23:07:39 +0100 Message-ID: <1495EA48-4F4D-424F-B918-71CAF57C67B2@swipnet.se> References: <87bnzo9cja.fsf@gnu.org> <59B7E7FC-48D0-4737-B1BB-FFAC5BA9E07A@swipnet.se> <874n5f3162.fsf@gnu.org> <83fvozf86g.fsf@gnu.org> <87r48javwe.fsf@gnu.org> <83bnzmfjxe.fsf@gnu.org> <87bnzlyvwb.fsf@gnu.org> <83wqi9cakl.fsf@gnu.org> <87zjn5584t.fsf@gnu.org> <8738kwydon.fsf@engster.org> <871u0dwiyv.fsf@engster.org> <87fvot2c18.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1389564485 14936 80.91.229.3 (12 Jan 2014 22:08:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 12 Jan 2014 22:08:05 +0000 (UTC) Cc: Eli Zaretskii , Stefan Monnier , Drew Adams , emacs-devel To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 12 23:08:11 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W2TCU-0002uK-H2 for ged-emacs-devel@m.gmane.org; Sun, 12 Jan 2014 23:08:10 +0100 Original-Received: from localhost ([::1]:39606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2TCU-0000Xh-1M for ged-emacs-devel@m.gmane.org; Sun, 12 Jan 2014 17:08:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2TCL-0000Xb-EX for emacs-devel@gnu.org; Sun, 12 Jan 2014 17:08:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2TCF-0006Vf-FQ for emacs-devel@gnu.org; Sun, 12 Jan 2014 17:08:01 -0500 Original-Received: from mailfe02.swip.net ([212.247.154.33]:48781 helo=swip.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2TC2-0006Lf-Tw; Sun, 12 Jan 2014 17:07:43 -0500 X-T2-Spam-Status: No, hits=0.8 required=5.0 tests=BAYES_50 Original-Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe02.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 468590366; Sun, 12 Jan 2014 23:07:39 +0100 In-Reply-To: <87fvot2c18.fsf@gnu.org> X-Mailer: Apple Mail (2.1827) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 212.247.154.33 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168252 Archived-At: Hello. 12 jan 2014 kl. 21:14 skrev Chong Yidong : > Instead, here's a compromise proposal: >=20 > - Allow :foreground to take the value of (fallback COLOR) or something > like that, which would be equivalent to setting :foreground to > unspecified and :distant-foreground to COLOR. >=20 > (We still need a replacement term for "distant foreground". As > mentioned before, this term sounds nonsensical.) >=20 There is a function called distant_color in the source, thats where it = comes from. > - In order to avoid incompatibilities, set the :foreground of the > `region' face to "*_selection_fg_color". In other words, avoid using > the above feature in the `region' face, at least for Emacs 24.4. >=20 > The rationale is that (i) we can live with having a fixed foreground > color for the `region' face, since that was the case in Emacs 24.3 on > GTK anyway. And (ii) not using this feature immediately gives > third-party packages a "transition period" to adapt to its presence, > without immediately failing by encountering it in a standard face. >=20 > If there are no objections, I can implement this. Count this as an objection. (i) means reopening a fixed bug BTW, don't = forget that. I don't think this should be done at all, but lets just consider 24.4: 1) We are talking about a replacing a feature that has no outstanding = bugs, and has been in place for about 2 months. 2) The only reason too replace it is some personal feelings about "clean = design", based on unknown principles, that are not documented in any = Emacs or GNU document. 3) The code for this proposal will be messier. Distant-foreground is = quite separate in the code, you can easily find any place where the = source handles to it. This proposal suggests modifying foreground, thus = changing a lot of places where foreground are handeled. Not only is = this bound to introduce bugs, but the feature is not as easily seen in = the source. And all this during a feature freeze? It makes feature freeze kind of = pointless if any feature can be replaced willy nilly based on a persons = design feelings. But this is Stefans call. Jan D.