From: Jarno Malmari <jarno@malmari.fi>
To: Colin Baxter <m43cap@yandex.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Fix potentially hanging url-auth tests
Date: Sun, 16 Apr 2017 14:21:45 +0300 [thread overview]
Message-ID: <1492341705.2601170.945983808.1744BCC1@webmail.messagingengine.com> (raw)
In-Reply-To: <87zifhvg2g.fsf@yandex.com>
On Sat, 15 Apr 2017, at 18:36, Colin Baxter wrote:
> This patch works for me. Great. Thank you.
Good to hear. Thanks for testing.
As you can see, the fix is local to the test itself. I think this is the
right approach since it is the responsibility of the test to know what
side effects the function calls have (reading the file .authinfo in this
case). The thing I'm not happy about is the possibility of reintroducing
the issue in the future. There's no check for that, but hopefully the
code comments give a clue what to avoid.
Sure, other testing facilities discussed earlier (customized HOME, or a
way to detect if run inside a test) might be useful but probably not
warranted solely by the issue here.
next prev parent reply other threads:[~2017-04-16 11:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 19:20 url-auth-tests hang if authinfo is encrypted Colin Baxter
2017-04-03 19:40 ` Eli Zaretskii
2017-04-04 6:15 ` Colin Baxter
2017-04-04 14:14 ` Eli Zaretskii
2017-04-15 9:12 ` [PATCH] Fix potentially hanging url-auth tests Jarno Malmari
2017-04-15 15:36 ` Colin Baxter
2017-04-16 11:21 ` Jarno Malmari [this message]
2017-04-04 14:53 ` url-auth-tests hang if authinfo is encrypted Ted Zlatanov
2017-04-04 16:04 ` Andreas Schwab
2017-04-04 20:03 ` Colin Baxter
2017-04-05 6:43 ` Colin Baxter
2017-04-05 13:33 ` Ted Zlatanov
2017-04-06 19:29 ` Jarno Malmari
2017-04-07 7:22 ` Colin Baxter
2017-04-07 7:37 ` Eli Zaretskii
2017-04-07 13:34 ` Colin Baxter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492341705.2601170.945983808.1744BCC1@webmail.messagingengine.com \
--to=jarno@malmari.fi \
--cc=emacs-devel@gnu.org \
--cc=m43cap@yandex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).