From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jarno Malmari Newsgroups: gmane.emacs.devel Subject: Re: Refactor digest authentication in url-auth Date: Tue, 14 Feb 2017 23:12:55 +0200 Message-ID: <1487106777-17025-1-git-send-email-jarno@malmari.fi> References: NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1487106904 10992 195.159.176.226 (14 Feb 2017 21:15:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 14 Feb 2017 21:15:04 +0000 (UTC) Cc: eliz@gnu.org To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 14 22:14:59 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdkR7-0002JT-Nw for ged-emacs-devel@m.gmane.org; Tue, 14 Feb 2017 22:14:57 +0100 Original-Received: from localhost ([::1]:37192 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdkRD-0006wf-5k for ged-emacs-devel@m.gmane.org; Tue, 14 Feb 2017 16:15:03 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdkQN-0006wI-2W for emacs-devel@gnu.org; Tue, 14 Feb 2017 16:14:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdkQL-0003l5-UV for emacs-devel@gnu.org; Tue, 14 Feb 2017 16:14:10 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:58162) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cdkQH-0003dh-4U; Tue, 14 Feb 2017 16:14:05 -0500 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B44EA2122C; Tue, 14 Feb 2017 16:14:02 -0500 (EST) Original-Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Tue, 14 Feb 2017 16:14:02 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=malmari.fi; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=jd8 V9KQ2xZT2nGxrD/oP5PImDRA=; b=hIbqx3DEtIALrrdHJkiWqkulw75siN71fqE sATII3NH/mP9DoNTH/ssvJ5ew8n6apV+sSC8fBy7HpBvtwyhIGgk96OLO979i3gw pV7vdpakog1HjXPvPRIztl527Un2js+ntq3QxDb+UZl0vxTmq2Ff3cmrhoKMZ5CF gaDpy14E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=smtpout; bh=jd8V9KQ2xZT2nGxrD/oP5PImDRA=; b=X3TIM Kq5w5rII1Ab7QpMS3u2e84cebfSlIE+7/uXWhhiEjr1AphCMdfzd96dLLKj391/t 9ITwrtBe7aTdErubPTgb4qKVKm3wBKfkBUzw2f2EGNtkOuaA3F/pHHxN2QequAkv GS5PGMyEF3CbVhCMiYZi+elz12JBxyXzmFi/Hc= X-ME-Sender: X-Sasl-enc: QYqzqkIAYc8Y89PsySVazICHgg4Jtty1hNoesQugAHKy 1487106842 Original-Received: from vabi.peto.intranet (a88-113-156-118.elisa-laajakaista.fi [88.113.156.118]) by mail.messagingengine.com (Postfix) with ESMTPA id E86BA7E399; Tue, 14 Feb 2017 16:14:01 -0500 (EST) X-Mailer: git-send-email 2.7.0.25.gfc10eb5 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212385 Archived-At: Here's a revised patch set for the earlier digest auth work. * Changed comments to follow gnu coding standards: two spaces between sentences, capital letter at beginning, period at the end, and the like * Removed bunch of references to RFC 2617 from docstrings. Still to understand what's being done requires you to pick that up, but mentioning it repeatedly doesn't help too much. * Changed the format of commit messages. * There were talk about what to call the "path component of an URI". Is it file-name part, directory, path, or URI path. I tried avoiding mentioning it but a few references remains and I ended up choosing "directory" since that's what's used in functions used here, namely: (url-file-directory (url-filename url)) The `url-file-directory' is defined in url-util with docstring: "Return the directory part of FILE, for a URL." Patches that follows: [PATCH 1/2] Refactor digest authentication in url-auth [PATCH 2/2] Initial implementation for HTTP Digest qop for url