From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Chong Yidong" Newsgroups: gmane.emacs.devel Subject: (no subject) Date: Tue, 1 Mar 2005 21:26:19 -0500 (EST) Message-ID: <1483.220.255.172.231.1109730379.squirrel@www.stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1109730875 22645 80.91.229.2 (2 Mar 2005 02:34:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 2 Mar 2005 02:34:35 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 02 03:34:34 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D6Jgt-0002YG-Br for ged-emacs-devel@m.gmane.org; Wed, 02 Mar 2005 03:34:23 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D6JzZ-0003Hw-2l for ged-emacs-devel@m.gmane.org; Tue, 01 Mar 2005 21:53:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D6Jyy-00035G-Kf for emacs-devel@gnu.org; Tue, 01 Mar 2005 21:53:04 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D6Jyi-0002yE-Hn for emacs-devel@gnu.org; Tue, 01 Mar 2005 21:52:52 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D6Jyh-0002tb-Bt for emacs-devel@gnu.org; Tue, 01 Mar 2005 21:52:47 -0500 Original-Received: from [64.21.80.18] (helo=shark.dnsvelocity.com) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1D6JZL-0000um-HS for emacs-devel@gnu.org; Tue, 01 Mar 2005 21:26:35 -0500 Original-Received: from stupidch by shark.dnsvelocity.com with local (Exim 4.44) id 1D6JZ5-00037g-CP for emacs-devel@gnu.org; Tue, 01 Mar 2005 21:26:19 -0500 Original-Received: from 220.255.172.231 ([220.255.172.231]) (SquirrelMail authenticated user cyd@stupidchicken.com) by www.stupidchicken.com with HTTP; Tue, 1 Mar 2005 21:26:19 -0500 (EST) Original-To: emacs-devel@gnu.org User-Agent: SquirrelMail/1.4.4 X-Priority: 3 (Normal) Importance: Normal X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - shark.dnsvelocity.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [32675 33085] / [47 12] X-AntiAbuse: Sender Address Domain - stupidchicken.com X-Source: /usr/local/cpanel/3rdparty/bin/php X-Source-Args: /usr/local/cpanel/3rdparty/bin/php /usr/local/cpanel/base/3rdparty/squirrelmail/src/compose.php X-Source-Dir: :/base/3rdparty/squirrelmail/src X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: main.gmane.org gmane.emacs.devel:34034 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34034 Could this patch be checked in? When require-final-newlines is t, the newline is inserted by (insert "\n"), which does not take use-hard-newlines into account, so the newline is not marked as 'hard. *** emacs/lisp/files.el~ Tue Mar 1 22:13:16 2005 --- emacs/lisp/files.el Wed Mar 2 10:16:52 2005 *************** *** 1661,1667 **** (= (char-after (1- (point-max))) ?\r))) (save-excursion (goto-char (point-max)) ! (insert "\n"))) (when (and buffer-read-only view-read-only (not (eq (get major-mode 'mode-class) 'special))) --- 1661,1667 ---- (= (char-after (1- (point-max))) ?\r))) (save-excursion (goto-char (point-max)) ! (newline))) (when (and buffer-read-only view-read-only (not (eq (get major-mode 'mode-class) 'special))) *************** *** 3244,3250 **** (buffer-name))))) (save-excursion (goto-char (point-max)) ! (insert ?\n)))) ;; Support VC version backups. (vc-before-save) (run-hooks 'before-save-hook) --- 3244,3250 ---- (buffer-name))))) (save-excursion (goto-char (point-max)) ! (newline)))) ;; Support VC version backups. (vc-before-save) (run-hooks 'before-save-hook)