From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Charles Strahan Newsgroups: gmane.emacs.devel Subject: Re: support for true-color terminals Date: Sun, 10 Apr 2016 22:16:24 -0400 Message-ID: <1460340984.2930993.574696385.6C600EFA@webmail.messagingengine.com> References: <1457660934.533185.545912986.04028913@webmail.messagingengine.com> <83y49pju8w.fsf@gnu.org> <1458288319.29675.552786858.0C058E99@webmail.messagingengine.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1460340997 9689 80.91.229.3 (11 Apr 2016 02:16:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Apr 2016 02:16:37 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 11 04:16:36 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1apRP1-0001hK-F8 for ged-emacs-devel@m.gmane.org; Mon, 11 Apr 2016 04:16:35 +0200 Original-Received: from localhost ([::1]:42773 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apRP0-0005rH-J9 for ged-emacs-devel@m.gmane.org; Sun, 10 Apr 2016 22:16:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apROv-0005oC-PE for emacs-devel@gnu.org; Sun, 10 Apr 2016 22:16:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1apROs-0008PM-IS for emacs-devel@gnu.org; Sun, 10 Apr 2016 22:16:29 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:41019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apROs-0008PH-Dp for emacs-devel@gnu.org; Sun, 10 Apr 2016 22:16:26 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id EB45520821 for ; Sun, 10 Apr 2016 22:16:24 -0400 (EDT) Original-Received: from web5 ([10.202.2.215]) by compute4.internal (MEProxy); Sun, 10 Apr 2016 22:16:24 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=cstrahan.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=ohTG1npZwrE7J0a85cS/0dVW/zY=; b=eIXXUq KC5/ElPWL1f4O0QAarhM9rMFxkj0ooXGw58dbSoaRCXGFRkOI4RptxkYuINMBJvO gZky1MLC79DZmsBJvco8mAOPd9wlQ0EoNRO6CMl+P239tFJMwAE9S1bWOVp+AYjj nDzZqAc5Sh4ATZBFka1PKXQvK/fomurJ/sFH8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=ohTG1npZwrE7J0a 85cS/0dVW/zY=; b=YFdQ+H2EBoBghP/+x11uhiTPcUxn5xeBBiMCTEIpd3zypIy hnYVtL2SrbnLk1ykYWR7Srft6Spp4WsVKe+d9iBPsZBQVNoQbnRzc7/QJEf84kSq RPMW8t0NHxG4iYGb/NUclABRrhFwASAt4ZIoJilWxfouBRD5ZhHzP97deEEM= Original-Received: by web5.nyi.internal (Postfix, from userid 99) id BDDD4AC5CEA; Sun, 10 Apr 2016 22:16:24 -0400 (EDT) X-Sasl-Enc: 7itGa8xb6ooMcyvCKcBUi+jjn90/d/T4tF5towjXUlon 1460340984 X-Mailer: MessagingEngine.com Webmail Interface - ajax-82e6ff7b In-Reply-To: <1458288319.29675.552786858.0C058E99@webmail.messagingengine.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.27 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:202846 Archived-At: Hello, Unless I've missed it, I don't think I've received an email regarding copyright assignment. Could you point me at the requisite paperwork, please? Thanks! -Charles On Fri, Mar 18, 2016, at 04:05 AM, Charles Strahan wrote: > On Fri, Mar 11, 2016, at 04:26 AM, Eli Zaretskii wrote: > > > From: Charles Strahan > > > Date: Thu, 10 Mar 2016 20:48:54 -0500 > > >=20 > > > A while back, there was an effort to add support for true-color > > > terminals (by which I mean terminals supporting 16777216 simultaneous > > > colors): > > >=20 > > > http://emacs.1067599.n5.nabble.com/RFC-Add-tty-True-Color-support-td2= 99962.html > > >=20 > > > I've contacted R=C3=BCdiger, asking if he wouldn't mind if I pick up = from > > > where he left off, and he said that was fine as he's been too busy to > > > work on this. > > >=20 > > > I've attached to this email the patch that I'm using, based on his wo= rk. > > > Any feedback would be greatly appreciated. > > >=20 > > > This is my first (attempted) contribution to Emacs, and I'm very new = to > > > the code base, so there might be some silly mistakes that I'm unaware > > > of. If we can get this polished enough for inclusion, I'd be more than > > > happy to assign copyright. > >=20 > > Thanks. > >=20 > > First, I suggest that you start the legal paperwork rolling right now, > > because without that, discussing such a non-trivial change would be > > rather pointless. If you agree, I will send you the form off-list. >=20 > Yes, I agree - thank you. I'll get the paperwork filled out as soon as I > can. >=20 > > As for the patch: my first comment is about the changes in > > tty_look_up_color and in map_tty_color -- why are these needed? The > > sheer number of the supported colors doesn't necessarily require any > > changes in the basic design of TTY color support, so I'm not sure what > > was the motivation for these changes. > >=20 > > Also, why do we need the 'true-color' option introduced in > > tty-colors.el? why isn't 'auto' enough for supporting this terminal? >=20 > I'll try to answer your questions in the next day or two when my > schedule frees up. >=20 > -Charles >=20