From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mitchel Humpherys Newsgroups: gmane.emacs.devel Subject: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region Date: Mon, 22 Feb 2016 17:04:31 -0800 Message-ID: <1456189471-18273-1-git-send-email-mitch.special@gmail.com> NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1456189485 23134 80.91.229.3 (23 Feb 2016 01:04:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Feb 2016 01:04:45 +0000 (UTC) Cc: mitch.special@gmail.com To: emacs-devel@gnu.org, Kristoffer Gronlund Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 23 02:04:38 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aY1P4-0007OX-8t for ged-emacs-devel@m.gmane.org; Tue, 23 Feb 2016 02:04:38 +0100 Original-Received: from localhost ([::1]:52956 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY1P3-0005y7-Pn for ged-emacs-devel@m.gmane.org; Mon, 22 Feb 2016 20:04:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY1Oz-0005up-MF for emacs-devel@gnu.org; Mon, 22 Feb 2016 20:04:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aY1Or-0001Hd-A3 for emacs-devel@gnu.org; Mon, 22 Feb 2016 20:04:29 -0500 Original-Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]:33049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY1Oq-0001HV-U7 for emacs-devel@gnu.org; Mon, 22 Feb 2016 20:04:25 -0500 Original-Received: by mail-pa0-x230.google.com with SMTP id fl4so100198023pad.0 for ; Mon, 22 Feb 2016 17:04:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=pFv1GxfU/a1/Hk06iBxZoWIirIG/DCSwybtSs2qK3Y0=; b=GPqbPN+sc2IeX4wSD0VD5GUGqIfgzz5ha/2U+rXTW5ROIFajJJgXwYKd6WMF/W22BM ptqHUknZtCtT2b6mDroXC9PSttbkzPrEL7WDPzzTYSk/1pbBfujoOJQLm0/6sWnjcSzQ 1PUK7FXpdxweEE/yi7MyDwVXoARjqQE6xUd7T++6D+Yzxc5gj324urjnSiCoM/qiTa+N GSx149yZhM9D4NNCVJuI3kRWuy5VrKEYSqIxU8e1cDT3ewQkonwmoxsBL5XXgNNbRYQz D9/MxeaQG3lU+mrru2fdd4jLdS3FYSkWBUkW5wQoSXS4lOf7JbDtXOPNsEUvOYH7B1ho +eMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pFv1GxfU/a1/Hk06iBxZoWIirIG/DCSwybtSs2qK3Y0=; b=KJfj9XKtuDWkVvl1tKOZpwR5Qxz8gw1zWO/UcmwgfJiMoOImaIZ+JJnprGw4UGOgOJ JugZweZ+5zHSSmKfGhD0oQNbdarGbCjVkTzH7eXxQ4LH1K6O5HSeMYyCQyo+/26N/ccX FSjfhZeTrrKgfKkBkxtui0c+yKvIKi/xC/jDfN6FDjsHGTZKkaxV8zv44G3p9Do5uI2W dkVPwmAIREfDRgCzwB2rqAhXbVw92Q4bds5WiaC53WF6YRNArtPUOjEUR6e3wq9ItAET p6zNvFJQNiwEVhQLhIquRjwG5bztqPZ6IRFvmH6NVhpbEvCZUzJ61l208qjSqJ7b3DhP N1Kg== X-Gm-Message-State: AG10YOSQzit4KRNYRSkT9x3OUhDElVVTMSBQodMngDA9z0NfSEB32ca1axRATsThUjfjIQ== X-Received: by 10.67.6.226 with SMTP id cx2mr42156781pad.93.1456189463683; Mon, 22 Feb 2016 17:04:23 -0800 (PST) Original-Received: from mitchelh-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id wh9sm39782091pab.8.2016.02.22.17.04.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 22 Feb 2016 17:04:23 -0800 (PST) X-Mailer: git-send-email 2.7.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200514 Archived-At: Setting a foreground color on the `region' face is slightly annoying. This is subjective, of course, but the consensus among other themes and around the web is to *not* set a foreground color on the region face. --- etc/themes/wombat-theme.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etc/themes/wombat-theme.el b/etc/themes/wombat-theme.el index 08ae12f2b13b..fec910f7fb53 100644 --- a/etc/themes/wombat-theme.el +++ b/etc/themes/wombat-theme.el @@ -36,7 +36,7 @@ wombat `(fringe ((,class (:background "#303030")))) `(highlight ((,class (:background "#454545" :foreground "#ffffff" :underline t)))) - `(region ((,class (:background "#444444" :foreground "#f6f3e8")))) + `(region ((,class (:background "#444444")))) `(secondary-selection ((,class (:background "#333366" :foreground "#f6f3e8")))) `(isearch ((,class (:background "#343434" :foreground "#857b6f")))) `(lazy-highlight ((,class (:background "#384048" :foreground "#a0a8b0"))))