From: "Michael R. Mauger" <michael@mauger.com>
To: Emacs-devel@gnu.org
Subject: Re: Patch for sql.el (quote table names in sql-list-table)
Date: Thu, 28 Jan 2016 14:23:25 -0700 (MST) [thread overview]
Message-ID: <1454016205681-385599.post@n5.nabble.com> (raw)
In-Reply-To: <87egd274so.fsf@ahungry.com>
I'd discourage this change. The List Tables prompt does not prevent use of
identifier enclosing characters and by not using them you get the default
case conversion behavior. There are also cases with MS SQL Server where the
enclosing character is not a single character but rather a [ and ] pair.
I'd also be concerned when I ask to list the table in another schema since
we'd now be enclosing the schema and table name within the quotes which is
clearly not what we want.
--
View this message in context: http://emacs.1067599.n5.nabble.com/Patch-for-sql-el-quote-table-names-in-sql-list-table-tp385543p385599.html
Sent from the Emacs - Dev mailing list archive at Nabble.com.
next prev parent reply other threads:[~2016-01-28 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 3:37 Patch for sql.el (quote table names in sql-list-table) Matthew Carter
2016-01-28 21:23 ` Michael R. Mauger [this message]
2016-01-29 2:55 ` Matthew Carter
2016-01-29 3:03 ` Matthew Carter
2016-01-30 5:31 ` Michael R. Mauger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454016205681-385599.post@n5.nabble.com \
--to=michael@mauger.com \
--cc=Emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).