From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ryan Yeske Newsgroups: gmane.emacs.devel Subject: Re: PATCH: Add the ability to give rcirc servers an alias name Date: Sun, 08 Nov 2015 10:52:04 -0800 Message-ID: <1447008724.187480.432504041.0E012C01@webmail.messagingengine.com> References: <877flsgut2.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1447008906 21322 80.91.229.3 (8 Nov 2015 18:55:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 Nov 2015 18:55:06 +0000 (UTC) Cc: Leo Liu , emacs-devel@gnu.org To: Artur Malabarba , Dave Barker Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 08 19:54:57 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZvV76-0000YD-NQ for ged-emacs-devel@m.gmane.org; Sun, 08 Nov 2015 19:54:52 +0100 Original-Received: from localhost ([::1]:48514 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvV76-0008Td-4J for ged-emacs-devel@m.gmane.org; Sun, 08 Nov 2015 13:54:52 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvV4U-00080h-9B for emacs-devel@gnu.org; Sun, 08 Nov 2015 13:52:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvV4Q-0006UG-89 for emacs-devel@gnu.org; Sun, 08 Nov 2015 13:52:10 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvV4Q-0006UC-05 for emacs-devel@gnu.org; Sun, 08 Nov 2015 13:52:06 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5149820334 for ; Sun, 8 Nov 2015 13:52:04 -0500 (EST) Original-Received: from web1 ([10.202.2.211]) by compute1.internal (MEProxy); Sun, 08 Nov 2015 13:52:04 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=ryanyeske.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=y8diKBWFunv5+CXwdGFa49ZFBIc=; b=AFHL7+ zJWz+GykN0MnaTd0LYPyvHOkwOM9sv68UvxeW8qUosoBHj4LgXlVrLYVhuCMIjTU svjxk/ePc1qN7I+qD7GNpk0O/iaQ0iijeNd2WnvP5k2IXYn1geuuN1xzQ+ABqjRr UzKciUYpj6VQo7Jx2a4XA8nrLY0eArudC3GHg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=y8diKBWFunv5+CX wdGFa49ZFBIc=; b=e+nk3dSY8aqCGzIXm+yav+zBBzlypkWUcWq4hzUIRfUs56K /oSEHGNMxEdxmDqnFrUgl+odtK7Kltvs3rJe89RQoNU0qx49CVwcrUkAlNJjk0ND HBeJz7zLYNB44x/GUgyxqMNYgrVCPqFuV1vwMUB0hfti/1KdT0JzPDc3EP8w= Original-Received: by web1.nyi.internal (Postfix, from userid 99) id 1DED8AECD05; Sun, 8 Nov 2015 13:52:04 -0500 (EST) X-Sasl-Enc: Rdm2eyg9hGhsEenHj7yH/jqhUzRhyfPbOx2QjjNh7YQ3 1447008724 X-Mailer: MessagingEngine.com Webmail Interface - ajax-643af86c In-Reply-To: <877flsgut2.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.25 X-Mailman-Approved-At: Sun, 08 Nov 2015 13:54:48 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193640 Archived-At: Where is the patch? On Sun, Nov 8, 2015, at 11:22 AM, Artur Malabarba wrote: > Dave Barker writes: >=20 > > Second try, reconnecting to servers now works again and the proper > > server names are displayed. > > > > (Also I forgot to mention before, patch applies > > to=A0ea88d874a4f3ecbfdb5fa79dcb3ea90927cebec2 ) >=20 > Hi Dave, >=20 > Your patch looks fine to me, but I'm not familiar with rcirc code. > Therefore. I've CC'd here Leo and Ryan who are listed as rcirc > maintainers in the file. >=20 > > > > Cheers, Dave. > > > > On Sat, Nov 7, 2015 at 11:00 PM, Dave Barker wrote: > > > > Hello all, > >=20=20=20=20 > > First time contributing to Emacs (or at least attempting to), > > sorry if I'm doing this wrong somehow. > >=20=20=20=20 > > I wanted the ability to give rcirc servers an alias name, to be > > displayed instead of the actual server name. The reason is that I > > use the ZNC IRC bouncer to connect to multiple servers and this > > means, as far as rcirc is concerned, that I have 4+ servers with > > the same server name - my ZNC server's hostname. This breaks > > rcirc, it won't let you connect to the same server twice, but > > even if it did things would quickly get confusing. (Up until now > > I've had to add bogus entries in my hosts file to point each IRC > > server's hostname to my ZNC server, but that's clearly quite a > > hack!) > >=20=20=20=20 > > So the attached patch adds an optional :server-alias keyword > > parameter to=A0rcirc-server-alist that allows you to specify a > > friendlier name for a rcirc server. The name is then used when > > messages are displayed, and for buffer naming purposes. If not > > specified the real server name is used instead just like before. > > (For people who are used to GitHub, here's my feature branch.) > >=20=20=20=20 > > It would be great to get some feedback on this, the patch is > > working great for me but I'm inexperienced with elisp and this is > > the first time I've had a look at the rcirc code. > >=20=20=20=20 > > Cheers, Dave.