From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jostein=20Kj=F8nigsen?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Handle output from Emacs byte-compilation properly Date: Mon, 14 Sep 2015 22:24:56 +0200 Message-ID: <1442262296.3420042.383512865.0F926D5F@webmail.messagingengine.com> References: <1442261679.3417325.383499481.7568CF24@webmail.messagingengine.com> Reply-To: jostein@kjonigsen.net NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_----------=_144226229634200420"; charset="utf-8" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1442299352 29751 80.91.229.3 (15 Sep 2015 06:42:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Sep 2015 06:42:32 +0000 (UTC) Cc: Jan Nieuwenhuizen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 15 08:42:25 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zbjwf-0006DY-Aa for ged-emacs-devel@m.gmane.org; Tue, 15 Sep 2015 08:42:25 +0200 Original-Received: from localhost ([::1]:45392 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbjwe-0002pH-Mc for ged-emacs-devel@m.gmane.org; Tue, 15 Sep 2015 02:42:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbaJB-0006IZ-GN for emacs-devel@gnu.org; Mon, 14 Sep 2015 16:25:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbaJ8-0002jp-4a for emacs-devel@gnu.org; Mon, 14 Sep 2015 16:25:01 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:33173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbaJ8-0002ja-0b for emacs-devel@gnu.org; Mon, 14 Sep 2015 16:24:58 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 82ADD205D5 for ; Mon, 14 Sep 2015 16:24:57 -0400 (EDT) Original-Received: from web3 ([10.202.2.213]) by compute4.internal (MEProxy); Mon, 14 Sep 2015 16:24:57 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-transfer-encoding :content-type:date:from:in-reply-to:message-id:mime-version :references:reply-to:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=ZF5m5+TTiefEuoVHNjN1upiLP+E=; b=CEhTNLlzNj7uGGtqq45SF+XAh/tM pfvPXKP97CAthIlM37vhXP39HtOfk+8QSYsfHrORA1uErKGLyY2oJNEGcbzA7Qev kWud1mUz60J2jkzQ57auI9k+PLnJ4SXsmor33yojXgjnpTO4DKWyIIRA5vK+QQPn HU4ZTbfN1UrIKzE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :reply-to:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=ZF5m5+ TTiefEuoVHNjN1upiLP+E=; b=Vteg7Rc4bpuS7MZOiIschB9WTph4Vtit1iKPdR K7MD8GJZgO28NTOPc+BkrYGUVvk1NK9gzcyxKTpVUEqN8g77mCb5st/F+NjUcXa1 1pOgjrHZzRZjtB67cqGc1TG24efiJ5YtZhxWc1oAjGobkfTUNDVRZAiwCaV/d5Kk N2Gkw= Original-Received: by web3.nyi.internal (Postfix, from userid 99) id 579E5102B48; Mon, 14 Sep 2015 16:24:56 -0400 (EDT) X-Sasl-Enc: ZJxtpS/b2QcBDEF1jfFMgXsOfEmsZBYwN8HvLUo7kuoG 1442262296 X-Mailer: MessagingEngine.com Webmail Interface - ajax-c76b43ce In-Reply-To: <1442261679.3417325.383499481.7568CF24@webmail.messagingengine.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.26 X-Mailman-Approved-At: Tue, 15 Sep 2015 02:42:03 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189965 Archived-At: This is a multi-part message in MIME format. --_----------=_144226229634200420 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="ISO-8859-1" The previous patch is not=A0 a good one and there's an error in it. Please disregard the previous patch and consider the attached patch instead. You'll have to take my word for it when I say I -did- test it before submitting. :) -- Jostein Kj=F8nigsen jostein@kjonigsen.net / jostein@secure.kjonigsen.net On Mon, Sep 14, 2015, at 10:14 PM, Jostein Kj=F8nigsen wrote: > It's common for module-developers to run Emacs byte-compilation in > separate build-scripts. >=20 > When invoking byte-compile on Emacs-lisp files you often get the > following headers: >=20 > - In toplevel form: > - In end of data: >=20 > When these errors show up in the output of a build-script initiated > through M-x compile and show up in a compilation-mode buffer, these > lines gets treated as guile-errors for files which doesn't exist. >=20 > This is due to the following regexp, which is quite frankly extremely > wide: >=20 > =A0 =A0 (guile-file "^In \\(.+\\):\n" 1) >=20 > This breaks prev-error and next-error based navigation because the > files "toplevel form" and "end of data" doesn't exist. >=20 > This patch ensures those lines are treated as information only before > getting to the guile-file regexp. >=20 > -- > Jostein Kj=F8nigsen > jostein@kjonigsen.net / jostein@secure.kjonigsen.net > Email had 1 attachment: > * compilation-mode-emacs-lisp.patch > =A0 2k (text/x-patch) --_----------=_144226229634200420 Content-Disposition: attachment; filename="compilation-mode-emacs-lisp.patch" Content-Id: <1442262217.3419732.00a62300cf47db205d7d403f9c80593a1ed8d337.03D76B68@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="compilation-mode-emacs-lisp.patch" RnJvbSA4YTJjMzlkY2QzZDI2MDlmNTcxZWFlOWZhMWExNmQzNGRiYTkxZjNj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9z dGVpbj0yMEtqPUMzPUI4bmlnc2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5l dD4KRGF0ZTogTW9uLCAxNCBTZXAgMjAxNSAyMTo0Mzo1NyArMDIwMApTdWJq ZWN0OiBbUEFUQ0hdIEhhbmRsZSBvdXRwdXQgZnJvbSBFbWFjcyBieXRlLWNv bXBpbGF0aW9uIHByb3Blcmx5CgpJdCdzIGNvbW1vbiBmb3IgbW9kdWxlLWRl dmVsb3BlcnMgdG8gcnVuIEVtYWNzIGJ5dGUtY29tcGlsYXRpb24gaW4Kc2Vw YXJhdGUgYnVpbGQtc2NyaXB0cy4KCldoZW4gaW52b2tpbmcgYnl0ZS1jb21w aWxlIG9uIEVtYWNzLWxpc3AgZmlsZXMgeW91IG9mdGVuIGdldCB0aGUKZm9s bG93aW5nIGhlYWRlcnM6CgotIEluIHRvcGxldmVsIGZvcm06Ci0gSW4gZW5k IG9mIGRhdGE6CgpXaGVuIHRoZXNlIGVycm9ycyBzaG93IHVwIGluIHRoZSBv dXRwdXQgb2YgYSBidWlsZC1zY3JpcHQgaW5pdGlhdGVkCnRocm91Z2ggTS14 IGNvbXBpbGUgYW5kIHNob3cgdXAgaW4gYSBjb21waWxhdGlvbi1tb2RlIGJ1 ZmZlciwgdGhlc2UKbGluZXMgZ2V0cyB0cmVhdGVkIGFzIGd1aWxlLWVycm9y cyBmb3IgZmlsZXMgd2l0aCB0aGUgcmVzcGVjdGl2ZSBuYW1lcwoidG9wbGV2 ZWwgZm9ybSIgYW5kICJlbmQgb2YgZGF0YSIuCgpUaGlzIGJyZWFrcyBwcmV2 LWVycm9yIGFuZCBuZXh0LWVycm9yIGJhc2VkIG5hdmlnYXRpb24uCgpUaGlz IHBhdGNoIGVuc3VyZXMgdGhvc2UgbGluZXMgYXJlIHRyZWF0ZWQgYXMgaW5m b3JtYXRpb24gb25seSBiZWZvcmUKZ2V0dGluZyB0byB0aGUgZ3VpbGUtZmls ZXMgcmVnZXhwLgotLS0KIGxpc3AvcHJvZ21vZGVzL2NvbXBpbGUuZWwgfCA1 ICsrKysrCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCgpkaWZm IC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvY29tcGlsZS5lbCBiL2xpc3AvcHJv Z21vZGVzL2NvbXBpbGUuZWwKaW5kZXggYTZlOWVkOC4uY2I1Yzg4NCAxMDA2 NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvY29tcGlsZS5lbAorKysgYi9saXNw L3Byb2dtb2Rlcy9jb21waWxlLmVsCkBAIC00NzcsNiArNDc3LDExIEBAIEZp bGUgPSBcXCguK1xcKSwgTGluZSA9IFxcKFswLTldK1xcKVxcKD86LCBDb2x1 bW4gPSBcXChbMC05XStcXClcXCk/IgogICAgICA7OwogICAgICAiXlxcKFte IFx0XHJcbihdK1xcKSAoXFwoWzAtOV0rXFwpOlxcKFswLTldK1xcKSkgIgog ICAgICAxIDIgMykKKworICAgIDs7IGVuc3VyZSBlbWFjcy1pbmZvIGhlYWRl cnMgYXJlIG5vdCB0cmVhdGVkIGFzIGd1aWxlLWVycm9ycy4KKyAgICA7OyBj cmVhdGVkIHVzaW5nIChyeCAob3IgIkluIHRvcGxldmVsIGZvcm06IiAiSW4g ZW5kIG9mIGRhdGE6IikpCisgICAgKGVsaXNwLWluZm8gIlxcKD86SW4gXFwo PzpcXCg/OmVuZCBvZiBkYXRhXFx8dG9wbGV2ZWwgZm9ybVxcKTpcXClcXCki IG5pbCBuaWwgbmlsIDApCisKICAgICAoZ3VpbGUtZmlsZSAiXkluIFxcKC4r XFwpOlxuIiAxKQogICAgIChndWlsZS1saW5lICJeICpcXChbMC05XStcXCk6 ICpcXChbMC05XStcXCkiIG5pbCAxIDIpCiAgICAgKQotLSAKMS45LjEKCgo= --_----------=_144226229634200420--