unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Backtrace mode
Date: Wed, 1 Aug 2018 17:07:41 -0400	[thread overview]
Message-ID: <13af8a72-c68b-7f83-10dd-82818b128f85@gmail.com> (raw)
In-Reply-To: <871sboqvx1.fsf@runbox.com>

On 2018-07-27 16:13, Gemini Lasswell wrote:
> - C functions in backtraces now get links to their source code. Links
> are also created for the reading position of 'eval-buffer' and
> 'eval-region'.

A small potential bug: if I install ido-completin-read+ emacs -Q, then running M-: (debug) produces a backtrace in which call-interactively isn't highlighted:

- Without ido-cr+ (all lines have a hyperlink to their sources):

  Debugger entered: nil
    eval((debug) nil)
    eval-expression((debug) nil nil 127)
    funcall-interactively(eval-expression (debug) nil nil 127)
    call-interactively(eval-expression nil nil)
    command-execute(eval-expression)
  
- With ido-cr+ (lines marked with ‘!’ don't have hyperlinks):

  Debugger entered: nil
    eval((debug) nil)
    eval-expression((debug) nil nil 127)
    funcall-interactively(eval-expression (debug) nil nil 127)
!   #<subr call-interactively>(eval-expression nil nil)
    apply(#<subr call-interactively> eval-expression (nil nil))
    call-interactively@ido-cr+-record-current-command(#<subr call-interactively> eval-expression nil nil)
    apply(call-interactively@ido-cr+-record-current-command #<subr call-interactively> (eval-expression nil nil))
!   call-interactively(eval-expression nil nil)
    command-execute(eval-expression)

I imagine this is due to advice? 

    :around advice: ‘call-interactively@ido-cr+-record-current-command’

Cheers,
Clément.



  parent reply	other threads:[~2018-08-01 21:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27 20:13 Backtrace mode Gemini Lasswell
2018-07-27 20:36 ` John Wiegley
2018-07-28 16:28 ` Eli Zaretskii
2018-08-01 15:22   ` Gemini Lasswell
2018-08-01 20:58 ` Clément Pit-Claudel
2018-08-03 15:48   ` Gemini Lasswell
2018-08-01 21:07 ` Clément Pit-Claudel [this message]
2018-08-03 17:14   ` Gemini Lasswell
2018-08-03 18:03     ` Clément Pit-Claudel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13af8a72-c68b-7f83-10dd-82818b128f85@gmail.com \
    --to=cpitclaudel@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).