From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Gian Fontanilla Newsgroups: gmane.emacs.devel Subject: Re: Patch for delete-indentation in simple.el Date: Fri, 23 Aug 2013 06:31:11 -0700 (PDT) Message-ID: <1377264671.59291.YahooMailBasic@web163405.mail.gq1.yahoo.com> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1377265125 28418 80.91.229.3 (23 Aug 2013 13:38:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Aug 2013 13:38:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 23 15:38:46 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VCrZY-00066Z-OX for ged-emacs-devel@m.gmane.org; Fri, 23 Aug 2013 15:38:40 +0200 Original-Received: from localhost ([::1]:37026 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCrZY-0005zb-Dw for ged-emacs-devel@m.gmane.org; Fri, 23 Aug 2013 09:38:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCrSV-0002BV-Uf for emacs-devel@gnu.org; Fri, 23 Aug 2013 09:31:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCrSL-00009W-Nt for emacs-devel@gnu.org; Fri, 23 Aug 2013 09:31:23 -0400 Original-Received: from nm46-vm6.bullet.mail.gq1.yahoo.com ([67.195.87.174]:40580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCrSL-00008t-E0 for emacs-devel@gnu.org; Fri, 23 Aug 2013 09:31:13 -0400 Original-Received: from [98.137.12.190] by nm46.bullet.mail.gq1.yahoo.com with NNFMP; 23 Aug 2013 13:31:12 -0000 Original-Received: from [98.137.12.223] by tm11.bullet.mail.gq1.yahoo.com with NNFMP; 23 Aug 2013 13:31:12 -0000 Original-Received: from [127.0.0.1] by omp1031.mail.gq1.yahoo.com with NNFMP; 23 Aug 2013 13:31:12 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 183070.55064.bm@omp1031.mail.gq1.yahoo.com Original-Received: (qmail 59597 invoked by uid 60001); 23 Aug 2013 13:31:12 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1377264671; bh=RTehjtAvVQoRlcISKjCT/++enf+fSHoG5Zaub57XROY=; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:Message-ID:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=2kqdESYm8x/bEJxSfzE1RjiN6fWsvqVFlDnNV0adQ6SG7xRSmJGqN2Jcd7OTdyLnWkOTf19FGfgQFCzGy232QPvhEKqk1+Tzb+j129s3osq/swsdEX2wfTVWY+kHIFqYq81IXJmOmD6lKNnnVdswp3bbWOEs1bQgH7DyVf9+PfA= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:Message-ID:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=EGb73/2oDnFbaxFgvNkeag7Y1kSCfrNMMbYAYfzYD+EZKrgAfhMpNhsfwsRz0irvmGsfLBFi63Ms7LDh97obdOIhyOv0TfEhNpPZsmudgUCyUfysB3yDs0YohaEZr8vwiJ8RZwqmHJBMGxoaZClItjZkirINpEnEtiaUtN1kS8I=; X-YMail-OSG: Kthgr8gVM1nNv94OEzz2flkZYs4BPuq.gAGDkXq5BFAUokf HPQ2.8da3CISL6ZvDJVzi Original-Received: from [112.203.20.14] by web163405.mail.gq1.yahoo.com via HTTP; Fri, 23 Aug 2013 06:31:11 PDT X-Rocket-MIMEInfo: 002.001, SnVzdCBzb21lIGNsYXJpZmljYXRpb25zOg0KDQoxKSBTaG91bGQgSSBjcmVhdGUgYSBzZXBhcmF0ZSBmdW5jdGlvbiB3aGljaCBkb2VzIGBkZWxldGUtaW5kZW50YXRpb24nIG9uIGEgcmVnaW9uLCBhbmQgbm90IGNoYW5nZSBgZGVsZXRlLWluZGVudGF0aW9uJyBpdHNlbGY_DQoNCjIpIElmIHRoZSBhbnN3ZXIgdG8gMSBpcyB5ZXMsIHdoYXQgbmFtZSBzaG91bGQgSSBnaXZlIGl0PyBUaGUgZmVhdHVyZSBJJ20gcHJvcG9zaW5nIGlzIHNlbWFudGljYWxseSBjbG9zZXIgdG8gImpvaW4gbGluZXMiLCByYXRoZXIBMAEBAQE- X-Mailer: YahooMailClassic/300 YahooMailWebService/0.8.155.576 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 67.195.87.174 X-Mailman-Approved-At: Fri, 23 Aug 2013 09:38:37 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162992 Archived-At: Just some clarifications: 1) Should I create a separate function which does `delete-indentation' on a= region, and not change `delete-indentation' itself? 2) If the answer to 1 is yes, what name should I give it? The feature I'm p= roposing is semantically closer to "join lines", rather than the inverse of= `fill-region' or `fill-paragraph', so I don't think it is correct to call = it "unfill". To further explain this, I envision this to be the inverse of = a "split" function (not `split-line') , which will split the line into seve= ral lines based on a delimiter (whitespace by default or user specified, or= can also be fill-prefix). So a line such as one-two-three-four when split given the delimiter (or prefix) "-", will turn into: one two three four Then, running "join lines" on the region should get it back to the original= line, granted that the prefix is "-"; otherwise the words will be separate= d by a single whitespace when prefix is nil. 3) > please use `use-region-p' and make the test from within the `interact= ive' spec rather than inside the function itself I can't say I understand this completely. This is assuming I am to change t= he body of `delete-indentation'? Regards, Gian -------------------------------------------- On Fri, 8/23/13, Stefan Monnier wrote: Subject: Re: Patch for delete-indentation in simple.el To: "Gian Fontanilla" Cc: emacs-devel@gnu.org Date: Friday, August 23, 2013, 5:03 AM =20 > I'm sending this improvement for delete-indentation in simple.el. Please see > attached files Description, ChangeLog, and Patch. =20 IIUC your suggestion is to make delete-indentation work on the region if active.=A0 That doesn't sound bad.=A0 Of course, another name for it is unfill-region, which has also been requested. =20 Could you provide a patch which does that (but please use `use-region-p' and make the test from within the `interactive' spec rather than inside the function itself)? =20 =20 =A0 =A0 =A0 =A0 Stefan =20 =20 PS: Just include your own ChangeLog comment rather than the whole ChangeLog file.