From: Dmitry Gutov <dgutov@yandex.ru>
To: Lars Ingebrigtsen <larsi@gnus.org>, Stefan Kangas <stefan@marxist.se>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master ad442b8: Make all vc-*-responsible-p functions return a string
Date: Mon, 15 Nov 2021 16:21:24 +0300 [thread overview]
Message-ID: <13513403-1f79-de43-6eb8-96e3bc6371a8@yandex.ru> (raw)
In-Reply-To: <87pmr386yi.fsf@gnus.org>
On 14.11.2021 11:41, Lars Ingebrigtsen wrote:
> Stefan Kangas<stefan@marxist.se> writes:
>
>> I believe this broke a test:
>>
>> 1 unexpected results:
>> FAILED vc-test-cvs01-register
> Yup. Should be fixed now.
FWIW, -responsible-p is documented to return non-nil rather than a
particular string, at the top of vc.el.
So it was the previous change that was (osensibly) broken, since we'd
generally use vc-root-dir to fetch said strings.
But I suppose this is a good change if it removes the need to hit the
disk twice. The description of 'responsible-p' needs to be updated,
though. Perhaps also describe what values can be returned by backends
which do not support 'root'.
next prev parent reply other threads:[~2021-11-15 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211114013858.24577.64348@vcs0.savannah.gnu.org>
[not found] ` <20211114013900.254D7209C6@vcs0.savannah.gnu.org>
2021-11-14 8:26 ` master ad442b8: Make all vc-*-responsible-p functions return a string Stefan Kangas
2021-11-14 8:41 ` Lars Ingebrigtsen
2021-11-15 13:21 ` Dmitry Gutov [this message]
2021-11-16 7:36 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13513403-1f79-de43-6eb8-96e3bc6371a8@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).